From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Wolfram Sang <wsa@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH -next] i2c: designware: Mark dw_i2c_plat_{suspend,resume}() as __maybe_unused
Date: Mon, 7 Mar 2022 10:13:52 +0200 [thread overview]
Message-ID: <58dc14d2-969e-256b-077c-2147827e5a86@linux.intel.com> (raw)
In-Reply-To: <b7f8ad61-4dcd-a7cd-94f5-2a37aa57fd6a@redhat.com>
On 3/4/22 13:46, Hans de Goede wrote:
> Hi,
>
> On 3/3/22 20:17, Nathan Chancellor wrote:
>> When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings
>> appear:
>>
>> drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function]
>> static int dw_i2c_plat_suspend(struct device *dev)
>> ^
>> drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function]
>> static int dw_i2c_plat_resume(struct device *dev)
>> ^
>> 2 errors generated.
>>
>> These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which
>> is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the
>> functions as __maybe_unused to make it clear that these functions might
>> be unused in this configuration.
>>
>> Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag")
>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-03-07 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 19:17 [PATCH -next] i2c: designware: Mark dw_i2c_plat_{suspend,resume}() as __maybe_unused Nathan Chancellor
2022-03-04 11:46 ` Hans de Goede
2022-03-07 8:13 ` Jarkko Nikula [this message]
2022-03-04 12:39 ` Andy Shevchenko
2022-03-08 14:17 ` Geert Uytterhoeven
2022-03-11 20:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58dc14d2-969e-256b-077c-2147827e5a86@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox