Re: [PATCH v2 6/6] media: qcom: camss: vfe: Add support for VFE 1080

Bryan O'Donoghue
2025-10-16T10:54:26Z

On 16/10/2025 11:33, Hangxiang Ma wrote:
>> But why ?
>>
>> ---
>> bod
> That a story. When testing the RDI path on Kaanapali, we found one image
> buffer starved at 19/20 stage. We want to capture 20 images but only 19
> received.
>
> On Kaanapali, the AUP and RUP are split into two separate registers not
> a single one. Maybe this hardware change impacts something. Calling
> ops->reg_update() in vfe_enable_output_v2 function only applies one
> buffer address. The downstream code defers AUP and RUP to CSID
> configuration stage. We mimic that and find it can solve this issue.
>
> ---
> Hangxiang

So this is the type of interesting detail that I'd go looking for in a
commit log, a comment in the code or a footnote in the cover letter.

One or two sentences in the commit log will do.

---
bod