Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080

Hangxiang Ma
2025-10-20T05:59:26Z

On 10/16/2025 5:12 PM, Bryan O'Donoghue wrote:
> On 15/10/2025 03:56, Hangxiang Ma wrote:
>> +    for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++)
>> +        if (csid->phy.en_vc & BIT(i)) {
>> +            val = readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i));
>> +            writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i));
>> +
>> +            if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET +
>> i)) {
>> +                /*
>> +                 * buf done and RUP IRQ have been moved to CSID from
>> VFE.
>> +                 * Once CSID received buf done, need notify VFE of this
>> +                 * event and trigger VFE to handle buf done process.
>> +                 */
>> +                camss_buf_done(csid->camss, csid->id, i);
>> +            }
>> +        }
>> +
> A multi-liner like this should be
>
> for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) {
>     /* etc */
> }
>
> in fact csid_reset_1080() does the right thing, please replicate.
>
Ack. Thanks.

---
Hangxiang