Re: [PATCH v2 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible

Hangxiang Ma
2025-10-20T04:13:21Z

On 10/16/2025 3:56 PM, Konrad Dybcio wrote:
> On 10/16/25 3:56 AM, Hangxiang Ma wrote:
>> On 10/16/2025 3:30 AM, Vladimir Zapolskiy wrote:
>>
>>> On 10/15/25 05:56, Hangxiang Ma wrote:
>>>> Add Kaanapali compatible consistent with CAMSS CCI interfaces. The list
>>>> of clocks for Kaanapali requires its own compat string 'cam_top_ahb',
>>>> aggregated into 'qcom,qcm2290-cci' node.
>>>>
>>>> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
>>>> ---
>>>>   Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 +++++-
>>>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>>> index 9bc99d736343..0140c423f6f4 100644
>>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>>> @@ -25,6 +25,7 @@ properties:
>>>>         - items:
>>>>             - enum:
>>>> +              - qcom,kaanapali-cci
>>>>                 - qcom,qcm2290-cci
>>>>                 - qcom,sa8775p-cci
>>>>                 - qcom,sc7280-cci
>>>> @@ -128,6 +129,7 @@ allOf:
>>>>           compatible:
>>>>             contains:
>>>>               enum:
>>>> +              - qcom,kaanapali-cci
>>>>                 - qcom,qcm2290-cci
>>>>       then:
>>>>         properties:
>>>> @@ -136,7 +138,9 @@ allOf:
>>>>             maxItems: 2
>>>>           clock-names:
>>>>             items:
>>>> -            - const: ahb
>>>> +            - enum:
>>>> +                - ahb
>>>> +                - cam_top_ahb
>>>
>>> Why is not to give the clock "ahb" name like on QCM2290?
>>>
>>> On QCM2290 the macro in front of the vlaue is GCC_CAMSS_TOP_AHB_CLK,
>>> and name "ahb" is good for both, I believe.
>>>
>>>>               - const: cci
>>>>     - if:
>>>>
>>>
>>
>> On Kaanapali the macro has been changed to CAM_CC_CAM_TOP_AHB_CLK. GCC clock domain doesn't manage the AHB clock but CAMCC does. I think it's better to create a new and more complete clock name to denote the differences between them.
>
> Are there any other "AHB" clocks going to this block?
>
> If not, then this is more confusing instead
>
> Konrad

On 10/16/2025 6:40 PM, Krzysztof Kozlowski wrote:
> On 16/10/2025 03:56, Hangxiang Ma wrote:
>>>
>>> On QCM2290 the macro in front of the vlaue is GCC_CAMSS_TOP_AHB_CLK,
>>> and name "ahb" is good for both, I believe.
>>>
>>>> - const: cci
>>>> - if:
>>>>
>>>
>>
>> On Kaanapali the macro has been changed to CAM_CC_CAM_TOP_AHB_CLK. GCC
>
>
> It seems you do not see the difference between GCC output clock and
> actual clock input so some other block.
>
>
>
> Best regards,
> Krzysztof

No more clocks will be added, at least for KNP. And I acknowledge the
substance of AHB clock doesn't change. I will update and keep AHB clock
name the same as QCM2290. Thanks for both of you. @Konrad @Krzysztof

---
Hangxiang