linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Len Brown" <lenb@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Takashi Iwai" <tiwai@suse.de>,
	"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire
Date: Sun, 15 Jan 2017 12:21:58 +0100	[thread overview]
Message-ID: <5aa8a3ab-a527-1f3b-0cf6-92fd4691ddc8@redhat.com> (raw)
In-Reply-To: <20170112184545.sejbzawnesu6zj5i@ninjato>

Hi,

On 12-01-17 19:45, Wolfram Sang wrote:
> On Sun, Jan 08, 2017 at 02:44:23PM +0100, Hans de Goede wrote:
>> Take the punit lock to stop others from accessing the punit while the
>> pmic i2c bus is in use. This is necessary because accessing the punit
>> from the kernel may result in the punit trying to access the pmic i2c
>> bus, which results in a hang when it happens while we own the pmic i2c
>> bus semaphore.
>>
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Tested-by: tagorereddy <tagore.chandan@gmail.com>
>
> I don't think the I2C patches need to go via I2C tree, so:
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>

Note that as mentioned in the cover-letter, these 2 i2c patches depend
on these:

https://patchwork.ozlabs.org/patch/710067/
https://patchwork.ozlabs.org/patch/710068/
https://patchwork.ozlabs.org/patch/710069/
https://patchwork.ozlabs.org/patch/710070/
https://patchwork.ozlabs.org/patch/710071/
https://patchwork.ozlabs.org/patch/710072/

Which all have many reviews / acks. Given the race between i915
and designware-i2c opened up by the last patch in this series
these not having been merged yet is a good thing, but patch 1-5
are ready for merging.

So Wolfram, what is the plan with these ? As said they are necessary
for the 2 i2c patches in this patch-set, so do you want the
entire set of 8 i2c patches to go through an other tree to avoid
inter tree dependencies ?

And if so, can we then have you're Acked-by for the 6 above too ?

Regards,

Hans

  reply	other threads:[~2017-01-15 11:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08 13:44 [PATCH 0/7] coordinate cht i2c-pmic and i915-punit accesses Hans de Goede
2017-01-08 13:44 ` [PATCH 1/7] x86/platform/intel/iosf_mbi: Add a mutex for punit access Hans de Goede
2017-01-08 15:16   ` Andy Shevchenko
2017-01-08 15:30     ` Hans de Goede
2017-01-08 15:35       ` Andy Shevchenko
2017-01-08 13:44 ` [PATCH 2/7] x86/platform/intel/iosf_mbi: Add a pmic bus access notifier Hans de Goede
2017-01-08 15:21   ` Andy Shevchenko
2017-01-08 13:44 ` [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire Hans de Goede
2017-01-08 15:27   ` Andy Shevchenko
2017-01-08 15:39     ` Hans de Goede
2017-01-12 18:45   ` Wolfram Sang
2017-01-15 11:21     ` Hans de Goede [this message]
2017-01-15 11:45       ` Wolfram Sang
2017-01-15 15:11         ` Hans de Goede
2017-01-15 15:17           ` Wolfram Sang
2017-01-08 13:44 ` [PATCH 4/7] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain Hans de Goede
2017-01-08 15:23   ` Andy Shevchenko
2017-01-12 18:45   ` Wolfram Sang
2017-01-08 13:44 ` [PATCH 5/7] drm/i915: Add intel_uncore_suspend / resume functions Hans de Goede
2017-01-08 13:44 ` [PATCH 6/7] drm/i915: Listen for pmic bus access notifications Hans de Goede
2017-01-08 13:44 ` [PATCH 7/7] drm/i915: Take punit lock when modifying punit settings Hans de Goede
2017-01-08 15:34   ` Andy Shevchenko
2017-01-08 15:42     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5aa8a3ab-a527-1f3b-0cf6-92fd4691ddc8@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=russianneuromancer@ya.ru \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).