From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B45FC433EF for ; Mon, 21 Feb 2022 08:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343700AbiBUIcx (ORCPT ); Mon, 21 Feb 2022 03:32:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343706AbiBUIcw (ORCPT ); Mon, 21 Feb 2022 03:32:52 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1409510FE4 for ; Mon, 21 Feb 2022 00:32:29 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BBAC3405A8 for ; Mon, 21 Feb 2022 08:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645432347; bh=TVZC7r8G6CEaD3eIO9b+oUrW2d/ZxrtJL667P7jAzwE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LcxaZXJRoaZZNSVfzR4pXprqQ1X+f4+YMx4YH0m8B4JJU8oTCBAMA81GzIg3QEP+c WPikNZrKeH9SQRq/sqpsl/8CNXlEJDERJRMpo78Wfw4lYsk1OhkKWta207ZeXXJBRY CnlZkaHfOHNfgTMQWHo8u34oLsOXTLZ7tr6QgDAMwuLzyPf8O3LNXQKj3+C82EVwnD XDffgpEu5+ycDFj59VwUjSZVB9NUoQ1zyCZJ3FERzq2NO2N5cEvNtelxs7e61WYm8e /unWX5s6/5wXOmgbP9oyRbiXqjQYVadmf5bo+aQQdokYMRi8va5S6ZyFc+DB6C5uNp FpaW0PFCIhe5g== Received: by mail-wr1-f70.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so7075864wrg.19 for ; Mon, 21 Feb 2022 00:32:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TVZC7r8G6CEaD3eIO9b+oUrW2d/ZxrtJL667P7jAzwE=; b=OgMcH3zx6p620oyG8dna/l2RJftg9l6W4SR7RQKXcLW5SYtsbbH2j3LjIUakFkKr/r pTZ3fiQgZjIKvdDHjjsD5PLJSiYaDdbf99vo3IMn95ksf3Gg4qrIvLp19cJFTrklrydf o5pb41WphBYAD7oMDsBdbx0CybN7hFAFF1ouyvNqwvh6TA7LYw0rsjxOrQx1coE+uVmi rhLZbQ+KaWYDXBHwsuwa83kBNP6SfuzhnBHxS0gMwaXHx3wo53WysLI4jYz3iBUHMRyb kkpwVBRKYv3xKRiN7/Mjyhs1qkvUObOXNny4N1NiBQpUA2Ccs7GVhsy1MucXvVsgI9bm DSDw== X-Gm-Message-State: AOAM533N6piMwYT5RlBZEYS7q72IbkT/sHPlGUGxV6F6BrBqfuCUXe+V dnzuqTg4F5QNv9Hsvj+8jtzlfHxrjX+sR7oUif0lwo+KFrw1V9TVm2w1UkmXiAxhK8aj13XfERk 0l0timkV5+RfetB1A/FPKJ1BfHlWtva/PIKjylg== X-Received: by 2002:a5d:6146:0:b0:1e6:16b6:3e99 with SMTP id y6-20020a5d6146000000b001e616b63e99mr14752138wrt.693.1645432346958; Mon, 21 Feb 2022 00:32:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJynWXDCyxnh3FFGUZaBfjSfsvzFafvVR9mLxa6NHv05YRkhHU0HA5xGoQ8svay3G9FKddP6HA== X-Received: by 2002:a5d:6146:0:b0:1e6:16b6:3e99 with SMTP id y6-20020a5d6146000000b001e616b63e99mr14752122wrt.693.1645432346730; Mon, 21 Feb 2022 00:32:26 -0800 (PST) Received: from [192.168.0.120] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id f18sm12660140wre.66.2022.02.21.00.32.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 00:32:26 -0800 (PST) Message-ID: <5ce0f6a6-4a5f-4f25-3cc6-ab0f24bf15cf@canonical.com> Date: Mon, 21 Feb 2022 09:32:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Content-Language: en-US To: Tyrone Ting Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, semen.protsenko@linaro.org, yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, digetx@gmail.com, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220220035321.3870-1-warp5tw@gmail.com> <5d507fda-525e-4064-3add-0bb0cc23d016@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 21/02/2022 09:16, Tyrone Ting wrote: > Hi Krzysztof: > > Thank you for your comments and please find my reply next to your comments. > > Krzysztof Kozlowski 於 2022年2月20日 > 週日 下午5:30寫道： >> >> On 20/02/2022 04:53, Tyrone Ting wrote: >>> From: Tyrone Ting >>> >>> This patchset includes the following fixes: >>> >>> - Add dt-bindings description for NPCM845. >>> - Bug fix for timeout calculation. >>> - Better handling of spurious interrupts. >>> - Fix for event type in slave mode. >>> - Removal of own slave addresses [2:10]. >>> - Support for next gen BMC (NPCM845). >>> >>> The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards. >>> >>> Addressed comments from: >>> - Jonathan Neuschäfer : https://lkml.org/lkml/2022/2/7/670 >>> - Krzysztof Kozlowski : https://lkml.org/lkml/2022/2/7/760 >> >> How did you address the ABI change comment? I still see you break the >> ABI with the introduction of a new, required property. >> > > I add the new, required property "nuvoton,sys-mgr" in the file > nuvoton-common-npcm7xx.dtsi. > The file nuvoton-common-npcm7xx.dtsi is required by the existing > upstream NPCM devicetree files. > It is also updated and committed in this patch set [PATCH v2 01/11] > arm: dts: add new property for NPCM i2c module. > Please let me know if I misunderstand the meaning of "breaking the ABI". > Thank you again. Breaking the ABI means that old DTS stop working with new kernel. Your change breaks old (and out-of-tree) DTS. What is more, your change is not bisectable because DTS goes via separate branch or tree than driver change. You need to keep old code as fallback, if getting nuvoton,sys-mgr fails. Best regards, Krzysztof