From: Stephen Boyd <swboyd@chromium.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq()
Date: Wed, 31 Jul 2019 07:46:47 -0700 [thread overview]
Message-ID: <5d41a9d8.1c69fb81.bdbb9.bea3@mx.google.com> (raw)
In-Reply-To: <20190731143011.GB1680@kunai>
Quoting Wolfram Sang (2019-07-31 07:30:11)
> > -dev_err(...);
>
> What about pr_err, ...?
Sure. I haven't tried to find these ones or pr_warn(), etc.
>
> > While we're here, remove braces on if statements that only have one
> > statement (manually).
>
> You can let cocci do this for you, too. From the top of my head:
>
> if (...)
> - {
> S
> - }
>
> with S being a statement and this rule depending on the matching rule.
>
Cool thanks for the tip! I'll have to try it out.
prev parent reply other threads:[~2019-07-31 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190730181557.90391-1-swboyd@chromium.org>
2019-07-30 18:15 ` [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-31 14:30 ` Wolfram Sang
2019-07-31 14:46 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d41a9d8.1c69fb81.bdbb9.bea3@mx.google.com \
--to=swboyd@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).