From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [3/3] i2c: exynos5: do not check TRANS_STATUS in case of Exynos7 variant Date: Fri, 26 Jan 2018 08:17:24 +0100 Message-ID: <5e27b754-17fa-3a98-0a99-ba93c16e5c0e@samsung.com> References: <20171130143007.30258-4-a.hajda@samsung.com> <20180115205334.6ciwq5pouthtj3kx@ninjato> <20180117232307.aigvkl564p4jzms3@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:50511 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbeAZHRa (ORCPT ); Fri, 26 Jan 2018 02:17:30 -0500 In-reply-to: <20180117232307.aigvkl564p4jzms3@ninjato> Content-language: en-US Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Andi Shyti , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "open list:I2C SUBSYSTEM" , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" On 18.01.2018 00:23, Wolfram Sang wrote: > On Tue, Jan 16, 2018 at 10:40:36AM +0100, Andrzej Hajda wrote: >> On 15.01.2018 21:53, Wolfram Sang wrote: >>> On Thu, Nov 30, 2017 at 03:30:07PM +0100, Andrzej Hajda wrote: >>>> HSI2C_MASTER_ST_LOSE state is not documented properly, extensive tests >>>> show that hardware is usually able to recover from this state without >>>> interrupting the transfer. On the other side enforcing transfer repetition >>>> in such case does not help in many situations, especially on busy systems >>>> and causes -EAGAIN and -ETIMEOUT errors. Moreover documentation says that >>>> such state can be caused by slave clock stretching, and should not be treated >>>> as an error. >>>> >>>> Signed-off-by: Andrzej Hajda >>> Can this be applied independently of my comments to patch 2? >>> >> Yes, please apply it alone. I will continue work on patch 2. > I just thought it might be nice to have a comment where you removed the > code summarizing your findings. So we will remember about this in the > future. Makes sense? > Forgive me delayed response - holiday. The code removed was something extra, so I am not sure if it is necessary to add comment to the code, git log should be enough. Anyway I will post patches dealing with HSI2C_MASTER_ST_LOSE on transaction start very soon, so I can add relevant comment there. Regards Andrzej