From: Markus Elfring <Markus.Elfring@web.de>
To: Cezar Chiru <chiru.cezar.89@gmail.com>,
linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 3/3] i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0.
Date: Sat, 18 Oct 2025 20:00:31 +0200 [thread overview]
Message-ID: <5e4c7964-0b15-4595-ba14-bbc0c71520fd@web.de> (raw)
In-Reply-To: <20251018091258.5266-4-chiru.cezar.89@gmail.com>
> Require spaces around '=', '>' and '<'. Add space(s) around binary
> operators.
> Move 'ret' variable inside for loop. Then check if (ret < 0) break.
> This improves usage of ret variable.
…
Is there a need to split desirable adjustments into two update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n81
Regards,
Markus
next prev parent reply other threads:[~2025-10-18 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 9:12 [PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Cezar Chiru
2025-10-18 9:12 ` [PATCH v7 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-10-18 9:12 ` [PATCH v7 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-10-18 9:12 ` [PATCH v7 3/3] i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0 Cezar Chiru
2025-10-18 18:00 ` Markus Elfring [this message]
2025-10-19 22:03 ` Andi Shyti
2025-10-19 22:07 ` [PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Andi Shyti
2025-10-19 22:10 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4c7964-0b15-4595-ba14-bbc0c71520fd@web.de \
--to=markus.elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=chiru.cezar.89@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox