* [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching
@ 2015-09-16 13:32 Nicola Corna
2015-10-20 15:35 ` Wolfram Sang
2015-10-27 19:14 ` Nicola Corna
0 siblings, 2 replies; 3+ messages in thread
From: Nicola Corna @ 2015-09-16 13:32 UTC (permalink / raw)
To: Wolfram Sang, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Nicola Corna
Added I2C_FUNC_NO_CLK_STRETCH, to be used when clock stretching is not
supported.
Signed-off-by: Nicola Corna <nicola-V0pQiMyom5mh6J55Ss3d3w@public.gmane.org>
---
Documentation/i2c/functionality | 1 +
include/uapi/linux/i2c.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/i2c/functionality b/Documentation/i2c/functionality
index 4aae8ed..f53807e 100644
--- a/Documentation/i2c/functionality
+++ b/Documentation/i2c/functionality
@@ -21,6 +21,7 @@ For the most up-to-date list of functionality constants, please check
I2C_M_REV_DIR_ADDR and I2C_M_NO_RD_ACK
flags (which modify the I2C protocol!)
I2C_FUNC_NOSTART Can skip repeated start sequence
+ I2C_FUNC_NO_CLK_STRETCH Does NOT support clock stretching
I2C_FUNC_SMBUS_QUICK Handles the SMBus write_quick command
I2C_FUNC_SMBUS_READ_BYTE Handles the SMBus read_byte command
I2C_FUNC_SMBUS_WRITE_BYTE Handles the SMBus write_byte command
diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
index b0a7dd6..59e4b43 100644
--- a/include/uapi/linux/i2c.h
+++ b/include/uapi/linux/i2c.h
@@ -88,6 +88,7 @@ struct i2c_msg {
#define I2C_FUNC_SMBUS_PEC 0x00000008
#define I2C_FUNC_NOSTART 0x00000010 /* I2C_M_NOSTART */
#define I2C_FUNC_SLAVE 0x00000020
+#define I2C_FUNC_NO_CLK_STRETCH 0x00000040 /* No check for SCL low */
#define I2C_FUNC_SMBUS_BLOCK_PROC_CALL 0x00008000 /* SMBus 2.0 */
#define I2C_FUNC_SMBUS_QUICK 0x00010000
#define I2C_FUNC_SMBUS_READ_BYTE 0x00020000
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching
2015-09-16 13:32 [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching Nicola Corna
@ 2015-10-20 15:35 ` Wolfram Sang
2015-10-27 19:14 ` Nicola Corna
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-10-20 15:35 UTC (permalink / raw)
To: Nicola Corna
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
On Wed, Sep 16, 2015 at 03:32:01PM +0200, Nicola Corna wrote:
> Added I2C_FUNC_NO_CLK_STRETCH, to be used when clock stretching is not
> supported.
>
> Signed-off-by: Nicola Corna <nicola@corna.info>
I think this should be rather a quirk than a functionality, i.e.
I2C_AQ_NO_CLK_STRETCH. Agree?
> ---
> Documentation/i2c/functionality | 1 +
> include/uapi/linux/i2c.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/i2c/functionality b/Documentation/i2c/functionality
> index 4aae8ed..f53807e 100644
> --- a/Documentation/i2c/functionality
> +++ b/Documentation/i2c/functionality
> @@ -21,6 +21,7 @@ For the most up-to-date list of functionality constants, please check
> I2C_M_REV_DIR_ADDR and I2C_M_NO_RD_ACK
> flags (which modify the I2C protocol!)
> I2C_FUNC_NOSTART Can skip repeated start sequence
> + I2C_FUNC_NO_CLK_STRETCH Does NOT support clock stretching
> I2C_FUNC_SMBUS_QUICK Handles the SMBus write_quick command
> I2C_FUNC_SMBUS_READ_BYTE Handles the SMBus read_byte command
> I2C_FUNC_SMBUS_WRITE_BYTE Handles the SMBus write_byte command
> diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
> index b0a7dd6..59e4b43 100644
> --- a/include/uapi/linux/i2c.h
> +++ b/include/uapi/linux/i2c.h
> @@ -88,6 +88,7 @@ struct i2c_msg {
> #define I2C_FUNC_SMBUS_PEC 0x00000008
> #define I2C_FUNC_NOSTART 0x00000010 /* I2C_M_NOSTART */
> #define I2C_FUNC_SLAVE 0x00000020
> +#define I2C_FUNC_NO_CLK_STRETCH 0x00000040 /* No check for SCL low */
> #define I2C_FUNC_SMBUS_BLOCK_PROC_CALL 0x00008000 /* SMBus 2.0 */
> #define I2C_FUNC_SMBUS_QUICK 0x00010000
> #define I2C_FUNC_SMBUS_READ_BYTE 0x00020000
> --
> 2.5.1
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching
2015-09-16 13:32 [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching Nicola Corna
2015-10-20 15:35 ` Wolfram Sang
@ 2015-10-27 19:14 ` Nicola Corna
1 sibling, 0 replies; 3+ messages in thread
From: Nicola Corna @ 2015-10-27 19:14 UTC (permalink / raw)
To: Wolfram Sang
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-i2c
October 20 2015 5:35 PM, "Wolfram Sang" <wsa@the-dreams.de> wrote:
> On Wed, Sep 16, 2015 at 03:32:01PM +0200, Nicola Corna wrote:
>
>> Added I2C_FUNC_NO_CLK_STRETCH, to be used when clock stretching is not
>> supported.
>>
>> Signed-off-by: Nicola Corna <nicola@corna.info>
>
> I think this should be rather a quirk than a functionality, i.e.
> I2C_AQ_NO_CLK_STRETCH. Agree?
>
I didn't know about these quirks, thanks. I'll update the patches, please review them.
Nicola Corna
>> ---
>> Documentation/i2c/functionality | 1 +
>> include/uapi/linux/i2c.h | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/Documentation/i2c/functionality b/Documentation/i2c/functionality
>> index 4aae8ed..f53807e 100644
>> --- a/Documentation/i2c/functionality
>> +++ b/Documentation/i2c/functionality
>> @@ -21,6 +21,7 @@ For the most up-to-date list of functionality constants, please check
>> I2C_M_REV_DIR_ADDR and I2C_M_NO_RD_ACK
>> flags (which modify the I2C protocol!)
>> I2C_FUNC_NOSTART Can skip repeated start sequence
>> + I2C_FUNC_NO_CLK_STRETCH Does NOT support clock stretching
>> I2C_FUNC_SMBUS_QUICK Handles the SMBus write_quick command
>> I2C_FUNC_SMBUS_READ_BYTE Handles the SMBus read_byte command
>> I2C_FUNC_SMBUS_WRITE_BYTE Handles the SMBus write_byte command
>> diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
>> index b0a7dd6..59e4b43 100644
>> --- a/include/uapi/linux/i2c.h
>> +++ b/include/uapi/linux/i2c.h
>> @@ -88,6 +88,7 @@ struct i2c_msg {
>> #define I2C_FUNC_SMBUS_PEC 0x00000008
>> #define I2C_FUNC_NOSTART 0x00000010 /* I2C_M_NOSTART */
>> #define I2C_FUNC_SLAVE 0x00000020
>> +#define I2C_FUNC_NO_CLK_STRETCH 0x00000040 /* No check for SCL low */
>> #define I2C_FUNC_SMBUS_BLOCK_PROC_CALL 0x00008000 /* SMBus 2.0 */
>> #define I2C_FUNC_SMBUS_QUICK 0x00010000
>> #define I2C_FUNC_SMBUS_READ_BYTE 0x00020000
>> --
>> 2.5.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-27 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 13:32 [RESEND PATCH 1/3] i2c: added FUNC flag for unsupported clock stretching Nicola Corna
2015-10-20 15:35 ` Wolfram Sang
2015-10-27 19:14 ` Nicola Corna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).