Re: [PATCH v4 1/9] i2c: atr: Fix lockdep for nested ATRs

Luca Ceresoli
2025-04-30T14:32:03Z

On Mon, 28 Apr 2025 13:25:06 +0300
Cosmin Tanislav <demonsingur@gmail.com> wrote:

> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>
> When we have an ATR, and another ATR as a subdevice of the first ATR,
> we get lockdep warnings for the i2c_atr.lock and
> i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
> for the locks, and doesn't see the locks of the separate ATR instances
> as separate.
>
> Fix this by generating a dynamic lock key per lock instance.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>

I'm not very qualified about the lockdep side of the changes, but
regarding the ATR side this looks OK:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering