From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: i801: Fix missing Kconfig dependency
Date: Mon, 8 Apr 2024 11:43:11 +0200 [thread overview]
Message-ID: <61cbe2cc-d334-4a2c-8cae-8cdaf8ad70f7@gmail.com> (raw)
In-Reply-To: <ixtm7tq4lpnaq64lesbgefphk2f7mmfnzarx7bgd4ydxl6ehma@ukzbhugjspvl>
On 08.04.2024 09:42, Wolfram Sang wrote:
>
>> Another simple solution would be to move the implementation of
>> i2c_root_adapter() from i2c mux to i2c core. It just uses
>> i2c_parent_is_i2c_adapter() which is an inline function of
>> i2c core. What do you think?
>
> I have no objections putting i2c_root_adapter() into the core. I think,
> however, that this patch makes the code a tad more readable. What is the
> downside of the symbol (despite we have way too many of those in
> general)?
>
I have no strong preference here, Andi mention that a new config symbol
wouldn't be his preferred approach. Therefore I brought up moving the
function to i2c core as an alternative.
Maybe he can elaborate on the reasoning.
next prev parent reply other threads:[~2024-04-08 9:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 20:09 [PATCH v2] i2c: i801: Fix missing Kconfig dependency Heiner Kallweit
2024-04-05 0:54 ` Andi Shyti
2024-04-05 5:57 ` Heiner Kallweit
2024-04-06 0:29 ` Andi Shyti
2024-04-06 19:52 ` Heiner Kallweit
2024-04-07 18:34 ` Heiner Kallweit
2024-04-08 7:42 ` Wolfram Sang
2024-04-08 9:43 ` Heiner Kallweit [this message]
2024-04-11 1:22 ` Andi Shyti
2024-04-11 6:44 ` Wolfram Sang
2024-04-11 9:56 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61cbe2cc-d334-4a2c-8cae-8cdaf8ad70f7@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox