From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09A83B7A8 for ; Thu, 16 Oct 2025 03:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760586409; cv=none; b=o3xnV1n/gcvbs1Ay6JY/uV/7zW1B3UnrXu0OKETjn22nBv6RrhCNiyziW3ov+Mvh0kM5vU26yDurWlxcBEMXiPLci7ziaAS1+xc1aGQU12PWyaGteZ0eG53bgqQXJwrhsAI1NPBg1qSPqFlyWimwBzoguHmHJMqhqX1IXSmm+ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760586409; c=relaxed/simple; bh=bJPo7L8epy+g4bqxcLXBIlhestqPQYX6FEF5Gq1U5pw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RUpVKhIWL56sHjQH3So3k5i5lxFZ9BtENvx+fo3hW2gMY6MeElruf/KW3ka6J7x3I7IO/3qlY/Ukwagab3Awln5ebbpJnQCh/CtbymabTZS18wx6axEDFqYAmAuIHzWMKKqm9Oo5yViyS76orJkWxIQtUxAyYwekps9UAcGaUEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eIQbq1SI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eIQbq1SI" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59FIK1Fm004061 for ; Thu, 16 Oct 2025 03:46:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MGTgW6j4BwUGWXfqHUc5yYYRAKlvIbby7H5r4Mivrcs=; b=eIQbq1SICN9HG5wf stkAI1Wt3m7VqM9Xf9HOrJiRN4baTQQuCoCoVvmzhm+RitAwVdxJKwRuBed93xI9 A6Txh/o4po8N3rlUq7U+dWYt4zQet+Rxv+ExmnbOY+HZbI5GRHstrGTvWcynU6S+ s3Ik/gVqk+bKNAWvYuKo6LYRnC3DOQNu9KXduP6d91kXAX49Yh/kGuaNI1UEPLIg EeJ7fpnx56MFrRGjXlwQFIVKNYLCv5r4r1kbJMnf3GZm6c1PIPusaJIW7FAQH2KW oiTBqLwPIvXykAiZECsONLURDdMiDBJJPV0c/9NQqpS+wOiNhX8YNKHDAiqNVjg2 oGSLRA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49s6mws4rq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 16 Oct 2025 03:46:47 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-28c58e009d1so6057095ad.3 for ; Wed, 15 Oct 2025 20:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760586406; x=1761191206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MGTgW6j4BwUGWXfqHUc5yYYRAKlvIbby7H5r4Mivrcs=; b=ICr4RnFO7VfnxdgGPMYzmlND3MptIZhyZpQBBDY6Re/8/MaXpwUTtCizS64BVwriA7 1KkTY2KfaA4erPTQ9GNeFPKZFmdbGd/eMVLPBnt231mIQPSiY75jAh0gy/S79m5tG4AQ yaiZqb1uyUHwGh/FZXJsBd4RjiB7CKkKEOHO3D6m/dwegtIo7HEximaWPSd/4k4BtGDG VYcwGgLnsIOLDslHN9qHVKXBX7yQFvwywF0StBPb9lYBqhnJH6vtp6254XqYSDmu9VW2 38ci79Q0rXRJM2Jdd1agzd4o0x3mUmfVEyXYjehS8pNxJ5q4KU3zCLjFpwoXwyu9iUNy 87DA== X-Gm-Message-State: AOJu0YwzWSJ1W9LChIwQ+QYPRaeMg0FH/XG+4M0wtgEJWSDRPHCtkSMk qn8nHtkPU5aFWK8SAJBa1D+GPpK8E05LW6MLGDrk+qw6uA5xzC/2wUPFiFdZnraaOScH6p7+Oaw XWkgokCkL92VWmofzPOTcjuXwKYJJQxDMEUIKqgi7PP+iQnuus+fh8NUZOTxg4aE= X-Gm-Gg: ASbGncu8RPe/q68SMRs77MnTiQBEdnIHNFYoyCW3+cTFi9vZXqe5Dz3WZYyJ8GOn0z2 504IhCo+tsAKtwtgPi0EcSgaGOE+5to5Mhgi+44WEEqC9wF1FkX8Mo6IhOIywO3dwlLqg8ei4FH 4vilI5AamaO6RLIhF8HTjvXSmhoxl6JA65tlYTNBio8UabMyRy7BAVpmFAhHLy2a3Ob9jQl2K9P JovfQO+rnMGgt8DzIOdIrDDPYtdW13QwB+LrxG+H8b1rVylrJcncMU16jVklc/lhRaUJL/xk3HX ld4hqHsl5efATTwY9pMf2OvfSQzT7z4AWke7/iiaGfxbQdEOSrCMFwud7p9LwzG0OYDH9ziN9V9 JQPJEmoLQmY09Os5Waf2tcve2KfmpVg== X-Received: by 2002:a17:903:2c0d:b0:269:b2ff:5c0e with SMTP id d9443c01a7336-290273ffa54mr419948625ad.46.1760586406217; Wed, 15 Oct 2025 20:46:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECrjW1cqPBNCEcpo2wlLgL0bF8Aw5ZIvKRkZrZUayiubVGdoGasv05AYsxFUK4g/KjMzTWFg== X-Received: by 2002:a17:903:2c0d:b0:269:b2ff:5c0e with SMTP id d9443c01a7336-290273ffa54mr419948165ad.46.1760586405736; Wed, 15 Oct 2025 20:46:45 -0700 (PDT) Received: from [192.168.1.57] ([98.148.145.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29099aba3fcsm12296275ad.99.2025.10.15.20.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 20:46:45 -0700 (PDT) Message-ID: <62a3f09b-50d6-4ace-8229-d71585378ae1@oss.qualcomm.com> Date: Wed, 15 Oct 2025 20:46:42 -0700 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Vladimir Zapolskiy , Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-2-f5745ba2dff9@oss.qualcomm.com> <0b6c157a-3d8d-4251-a704-31f8369f6a4e@linaro.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDEzMDA4MyBTYWx0ZWRfX/fLmiy+zhS00 Rt7DvyS4RijDck1UnGXqePPjDUK2odIeyPxKk0mCe4jpNaLlr0mqLKmXothV9FhfUVthl8uZbs6 uIUjOMcbfYNXF1tMwcBTiNCWzKEkNkdrCIW85A7Lw7ahb+hWCFAY5c4VLVsB8Yzcp2JumGnr2tH BHGFQNJnhRp+5ttxoIfGjkDGJ2/t9ooboN/y8xOC96AoJ+sHXCV613U6IW7+gnPKDdMjPxDwdsl x7GiF7Wym6BKL909H1ma6CgTgZNgqt3QiPKeO8BslhMVrV9lvWgAB9XkyTd508Y7SBiT4ugC7bP c9o4zyPBVx8cmDfGQx1/56LhKwB5vzXGdeord6JG93PNTq5TKx2bSgxz/vnLexjsrI5XXLatmG6 ozK/HSg+/F3snThTnOU0wE5ZSNUUlw== X-Authority-Analysis: v=2.4 cv=Fr4IPmrq c=1 sm=1 tr=0 ts=68f06aa7 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=BiHMn5M11h/vNwziJwzFrg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=CagpHDX3wZ8s8GLuJqoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: guukY1hz5Bb2lo4pW5dJnMW040RXo_w9 X-Proofpoint-ORIG-GUID: guukY1hz5Bb2lo4pW5dJnMW040RXo_w9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-15_07,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510130083 On 10/15/2025 4:32 PM, Vladimir Zapolskiy wrote: > On 10/16/25 00:43, Bryan O'Donoghue wrote: >> On 15/10/2025 20:45, Vladimir Zapolskiy wrote: >>>> +  power-domains: >>>> +    items: >>>> +      - description: >>>> +          TFE0 GDSC - Thin Front End, Global Distributed Switch >>>> Controller. >>>> +      - description: >>>> +          TFE1 GDSC - Thin Front End, Global Distributed Switch >>>> Controller. >>>> +      - description: >>>> +          TFE2 GDSC - Thin Front End, Global Distributed Switch >>>> Controller. >>>> +      - description: >>>> +          Titan GDSC - Titan ISP Block Global Distributed Switch >>>> Controller. >>>> + >>>> +  power-domain-names: >>>> +    items: >>>> +      - const: tfe0 >>>> +      - const: tfe1 >>>> +      - const: tfe2 >>> >>> Please remove all 'tfeX' power domains, they are not going to be >>> utilized >>> any time soon. >>> >>> When 'power-domains' list is just a single Titan GDSC, >>> 'power-domain-names' >>> property is not needed. >> >> Each one of these TFEs powers an individually power-collapsible TFEs. >> >> This is also so with the other xFE power-domains on previous SoC >> generations. > > This is false, for instance there is no management of SFEx power domains > in SM8550 or X1E80100 CAMSS in the upstrem, neither there is no > management > of SBI, IPE, BPS, CPP and so on GDSC power domans given by CAMCCs. > > TFEx is no more special, if it's unused, then it should not be added. I agree with Bryan, if I understood the original comment correctly. This is no different to the IFE0/1/2 GDSCs on SM8550. All the other modules listed above (SFE, IPE, BPS etc.) are not supported by the CAMSS driver and hence there is no management. However, we need to manage the TOP and TFE0/1/2 GDSCs for the real time RDI paths. > > >> >> You'll need the TFEx power-domain to process any data on TFEx with the >> 'lite' versions being tied to the TOP GDSC. > > When it is needed, the documentation will be updated accordingly, > right now > it is unknown what a data processing on TFEx looks like, it might happen > that there will be separate device tree nodes for TFEx. > > TFEx power domains shall be removed right now, unti; a usecase in the > upstream > CAMSS appears to use them, I haven't seen such code at the moment. > We attach these power power domains by name in the corresponding driver. For instance, the VFE driver attaches the TFE power domains mentioned here and are exercised from vfe_set_power() -> vfe_get() ->vfe_pm_domain_on(). You can also see the related codes with '.has_pd' and '.pd_name' properties in the CAMSS subdev resource structures. Hope this clarifies.