From mboxrd@z Thu Jan 1 00:00:00 1970 From: alokc@codeaurora.org Subject: Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler Date: Thu, 04 Oct 2018 13:16:26 +0530 Message-ID: <63135265545c5da50522e346e2a2d311@codeaurora.org> References: <20180924235235.182649-1-swboyd@chromium.org> <20180924235235.182649-3-swboyd@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Stephen Boyd , Wolfram Sang , LKML , linux-i2c@vger.kernel.org, linux-arm-msm , Karthikeyan Ramasubramanian , Sagar Dharia , Girish Mahadevan , linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 2018-09-26 03:19, Doug Anderson wrote: > Hi, > > On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd > wrote: >> >> We don't need to use goto here, we can just collapse the if statement >> and goto chain into multiple branches and then combine some duplicate >> completion calls into one big if statement. Let's do it to clean up >> code >> some more. >> >> Cc: Karthikeyan Ramasubramanian >> Cc: Sagar Dharia >> Cc: Girish Mahadevan >> Cc: Doug Anderson >> Signed-off-by: Stephen Boyd >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 70 >> +++++++++++++----------------- >> 1 file changed, 29 insertions(+), 41 deletions(-) > > It doesn't gleam as powerfully the cleanups in patch 2/3 but this does > have a few nice readability improvements. > > Reviewed-by: Douglas Anderson agree. Reviewed-by: Alok Chauhan -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,a Linux Foundation Collaborative Project