From: Jan Kandziora <jjj@gmx.de>
To: GregKH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Evgeniy Polyakov <zbr@ioremap.net>,
Linux-I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] wire: export w1_touch_bit
Date: Mon, 18 Sep 2017 21:34:27 +0200 [thread overview]
Message-ID: <642d1ff1-57ff-71ee-a516-c6028dd1d1c2@gmx.de> (raw)
In-Reply-To: <20170918141929.GA10178@kroah.com>
Am 18.09.2017 um 16:19 schrieb GregKH:
> On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
>> The w1_ds28e17 driver from the next part of this patch needs to emit
>> single-bit read timeslots to the DS28E17. The w1 subsystem already
>> has this function but it is not exported outside drivers/w1/w1_io.c
>>
>> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
>> same as the other exported symbols in drivers/w1/w1_io.c
>>
>> May be also useful later for writing drivers for other Onewire chips
>> which do single-bit communication.
>>
>> Signed-off-by: Jan Kandziora <jjj@gmx.de>
>> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>> ---
>> Changes in v4 against v3 in this subpatch:
>> - adapted to linux-4.12.0
>>
>> No changes in v3 against v2,v1 in this subpatch.
>
> You should change it as it does not apply to 4.14-rc1 :(
>
Okay, I will review them again.
> Please rebase your patches and resend them, with Evgeniy's acks added to
> them.
>
Now you caught me. I don't know how to do that. What's required? The
Acked-by: line? Am I allowed to simply add these lines to my patches or
is there a procedure to follow?
Kind regards
Jan
next prev parent reply other threads:[~2017-09-18 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 13:03 [PATCH v4 1/2] wire: export w1_touch_bit Jan Kandziora
2017-09-18 13:03 ` [PATCH v4 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge Jan Kandziora
2017-09-18 14:19 ` [PATCH v4 1/2] wire: export w1_touch_bit GregKH
2017-09-18 19:34 ` Jan Kandziora [this message]
2017-09-18 19:37 ` GregKH
2017-09-20 21:54 ` Jan Kandziora
-- strict thread matches above, loose matches on Subject: below --
2017-07-19 20:14 Jan Kandziora
2017-08-27 7:21 ` Evgeniy Polyakov
2017-07-10 22:59 Jan Kandziora
2017-07-13 15:13 ` Evgeniy Polyakov
2017-07-17 14:47 ` Greg Kroah-Hartman
2017-07-17 22:56 ` Jan Kandziora
2017-07-18 4:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642d1ff1-57ff-71ee-a516-c6028dd1d1c2@gmx.de \
--to=jjj@gmx.de \
--cc=greg@kroah.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).