From: Jon Hunter <jonathanh@nvidia.com>
To: Kartik Rajput <kkartik@nvidia.com>,
ldewangan@nvidia.com, digetx@gmail.com, andi.shyti@kernel.org,
thierry.reding@gmail.com, akhilrajeev@nvidia.com,
smangipudi@nvidia.com, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] i2c: tegra: Add logic to support different register offsets
Date: Fri, 9 Jan 2026 09:50:18 +0000 [thread overview]
Message-ID: <650d72a0-cdd2-4c24-adca-40196b265c7b@nvidia.com> (raw)
In-Reply-To: <27c283ca-a7d8-41eb-8fed-0ee9d08f26c5@nvidia.com>
On 08/01/2026 08:53, Jon Hunter wrote:
...
> Thinking about this some more I had a tough time reviewing this and feel
> that this transition is error prone. I would prefer if we kept the
> current definitions and then just ...
>
> static const struct tegra_i2c_regs tegra20_i2c_regs = {
> .cnfg = I2C_CNFG,
> ...
> };
>
> static const struct tegra_i2c_regs tegra20_dvc_i2c_regs = {
> .cnfg = DVC_OFFSET(I2C_CNFG),
> ...
> };
>
> static const struct tegra_i2c_regs tegra210_vi_i2c_regs = {
> .cnfg = VI_OFFSET(I2C_CNFG),
> ...
> };
I spoke to Thierry and his preference is to get rid of the definitions
and use the raw value in the structure. That is fine, but we should make
sure these structures are created with the correct data.
Jon
--
nvpublic
next prev parent reply other threads:[~2026-01-09 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 14:26 [PATCH v5 0/4] Add I2C support for Tegra410 Kartik Rajput
2026-01-07 14:26 ` [PATCH v5 1/4] i2c: tegra: Introduce tegra_i2c_variant to identify DVC and VI Kartik Rajput
2026-01-07 14:26 ` [PATCH v5 2/4] i2c: tegra: Move variant to tegra_i2c_hw_feature Kartik Rajput
2026-01-07 14:26 ` [PATCH v5 3/4] i2c: tegra: Add logic to support different register offsets Kartik Rajput
2026-01-07 15:11 ` Jon Hunter
2026-01-08 8:33 ` Kartik Rajput
2026-01-08 8:53 ` Jon Hunter
2026-01-09 9:50 ` Jon Hunter [this message]
2026-01-07 14:26 ` [PATCH v5 4/4] i2c: tegra: Add support for Tegra410 Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650d72a0-cdd2-4c24-adca-40196b265c7b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=digetx@gmail.com \
--cc=kkartik@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox