From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Wojciech Siudy (Nokia)" <wojciech.siudy@nokia.com>
Cc: Rob Herring <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"peda@axentia.se" <peda@axentia.se>
Subject: Re: ODP: [PATCH v5 1/2] dt-bindings: i2c: pca954x: Add timeout reset property
Date: Thu, 24 Oct 2024 09:08:57 +0200 [thread overview]
Message-ID: <655e9afc-cfe9-4b52-8308-7ffe1011e6d5@kernel.org> (raw)
In-Reply-To: <DB6PR07MB350922B1A1458EE3D7EB3F019D4E2@DB6PR07MB3509.eurprd07.prod.outlook.com>
On 24/10/2024 09:05, Wojciech Siudy (Nokia) wrote:
> Hello,
>
>> This is reset of the I2C devices (children), not the controller, right?
> Right, the mux is child device.
Not sure to which part I replied to. I have DT 200 emails in inbox per
day, I respond to less but still more than I can track. Keep some context.
I suspect you are adding reset for some other device, not for the one here.
>
>> switch to reset controller framework
> Please note that I left the function pca954x_reset_deassert() unchanged,
> just moved it up and implemented two corresponding ones.
> Do you mean that we should get rid of gpiod_set_value_cansleep(),
> because the reset controller will handle it? I can agree but this is topic
> for another submission since there we change when the reset is done,
> not the way we achieve that.
No, I meant I suspect you place property in inappropriate binding to
avoid shared GPIO problem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-24 7:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 10:03 [PATCH v5 0/2] pca954x: Add DT bindings and driver changes for reset after timeout Wojciech Siudy
2024-10-18 10:03 ` [PATCH v5 1/2] dt-bindings: i2c: pca954x: Add timeout reset property Wojciech Siudy
2024-10-18 13:53 ` Rob Herring
2024-10-19 11:09 ` Wojciech Siudy (Nokia)
2024-10-21 7:27 ` Krzysztof Kozlowski
2024-10-24 7:05 ` ODP: " Wojciech Siudy (Nokia)
2024-10-24 7:08 ` Krzysztof Kozlowski [this message]
2024-10-24 9:18 ` Wojciech Siudy (Nokia)
2024-10-24 9:40 ` Krzysztof Kozlowski
2024-10-18 10:03 ` [PATCH v5 2/2] pca954x: Reset if channel select fails Wojciech Siudy
2024-10-24 10:59 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655e9afc-cfe9-4b52-8308-7ffe1011e6d5@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=wojciech.siudy@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox