Re: [PATCH v5 1/2] dt-bindings: i2c: mv64xxx: add bus-reset-gpios property

Wolfram Sang
2023-10-27T09:10:05Z

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

On Fri, Oct 27, 2023 at 04:31:03PM +1300, Chris Packham wrote:
> Add bus-reset-gpios and bus-reset-duration-us properties to the
> marvell,mv64xxx-i2c binding. These can be used to describe hardware
> where a common reset GPIO is connected to all downstream devices on and
> I2C bus. This reset will be asserted then released before the downstream
> devices on the bus are probed.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Krzysztof, are you fine with this change?

> ---
>
> Notes:
> Changes in v5:
> - Rename reset-gpios and reset-duration-us to bus-reset-gpios and
> bus-reset-duration-us as requested by Wolfram
> Changes in v4:
> - Add r-by from Krzysztof
> Changes in v3:
> - Rename reset-delay-us to reset-duration-us to better reflect its
> purpose
> - Add default: for reset-duration-us
> - Add description: for reset-gpios
> Changes in v2:
> - Update commit message
> - Add reset-delay-us property
>
> .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index 461d1c9ee3f7..b165d1c4f0b1 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -70,6 +70,16 @@ properties:
> resets:
> maxItems: 1
>
> + bus-reset-gpios:
> + description:
> + GPIO pin providing a common reset for all downstream devices. This GPIO
> + will be asserted then released before the downstream devices are probed.
> + maxItems: 1
> +
> + bus-reset-duration-us:
> + description: Reset duration in us.
> + default: 1
> +
> dmas:
> items:
> - description: RX DMA Channel
> --
> 2.42.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]