From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: alexandre.torgue@st.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
Date: Wed, 4 Sep 2019 09:47:07 +0200 [thread overview]
Message-ID: <662b171f-37e2-f58e-3e05-41a52737b1f3@st.com> (raw)
In-Reply-To: <20190903180552.GI2171@ninjato>
Hi Wolfram
Sorry for the delay.
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
BR
On 9/3/19 8:05 PM, Wolfram Sang wrote:
> On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
>> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
>> when it is assigned to constant field algo of a variable having type
>> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
>> const as well to protect it from unintended modification.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>
> Are you guys okay with this patch?
>
>> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
>> index 266d1c269b83..d36cf08461f7 100644
>> --- a/drivers/i2c/busses/i2c-stm32f7.c
>> +++ b/drivers/i2c/busses/i2c-stm32f7.c
>> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
>> I2C_FUNC_SMBUS_I2C_BLOCK;
>> }
>>
>> -static struct i2c_algorithm stm32f7_i2c_algo = {
>> +static const struct i2c_algorithm stm32f7_i2c_algo = {
>> .master_xfer = stm32f7_i2c_xfer,
>> .smbus_xfer = stm32f7_i2c_smbus_xfer,
>> .functionality = stm32f7_i2c_func,
>> --
>> 2.19.1
>>
next prev parent reply other threads:[~2019-09-04 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 5:58 [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant Nishka Dasgupta
2019-09-03 18:05 ` Wolfram Sang
2019-09-04 7:47 ` Pierre Yves MORDRET [this message]
2019-09-04 21:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662b171f-37e2-f58e-3e05-41a52737b1f3@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).