Re: [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for K1 SoC

Troy Mitchell
2024-10-29T08:36:08Z

On 2024/10/28 15:38, Krzysztof Kozlowski wrote:
> On Mon, Oct 28, 2024 at 01:32:19PM +0800, Troy Mitchell wrote:
>> The I2C of K1 supports fast-speed-mode and high-speed-mode,
>> and supports FIFO transmission.
>>
>> Signed-off-by: Troy Mitchell <TroyMitchell988@gmail.com>
>> ---
>
> Where is the changelog? Nothing here, nothing in cover letter.
>
> I asked for several changes, so now I don't know if you implemented
> them.

I deleted the FIFO property because I believe your suggestion is correct.
this should be decided by the driver, even though the FIFO is provided
by the hardware.

Apologies for missing the changelog. To correct this, should I send a v3
version with the changelog or resend v2?
>
> Best regards,
> Krzysztof
>