From: Guenter Roeck <linux@roeck-us.net>
To: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Yin <peteryin.openbmc@gmail.com>,
Noah Wang <noahwang.wang@outlook.com>,
Marek Vasut <marex@denx.de>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v2 2/2] hwmon: pmbus: add driver for ltp8800-1a, ltp8800-4a, and ltp8800-2
Date: Wed, 6 Nov 2024 17:45:22 -0800 [thread overview]
Message-ID: <697a9596-f5aa-48d0-ad26-ebe06b831ee8@roeck-us.net> (raw)
In-Reply-To: <20241106030918.24849-3-cedricjustine.encarnacion@analog.com>
On 11/5/24 19:09, Cedric Encarnacion wrote:
> LTP8800-1A 54V, 150A DC/DC µModule Regulator with PMBus Interface
> LTP8800-4A 54V, 200A DC/DC µModule Regulator with PMBus Interface
> LTP8800-2 54V, 135A DC/DC μModule Regulator with PMBus Interface
>
> The LTP8800 is a family of step-down μModule regulators that provides
> microprocessor core voltage from 54V power distribution architecture. It
> features telemetry monitoring of input/output voltage, input current,
> output power, and temperature over PMBus.
>
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
Looking closer into the datasheets, I found that the PMBus commands are identical
to those of ADP1055, and an extension of the ADP1050 driver to support ADP1055
has been submitted.
With this in mind, please explain why this series warrants a new driver instead
of just extending the existing driver to support LTP8800.
Thanks,
Guenter
next prev parent reply other threads:[~2024-11-07 1:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 3:09 [PATCH v2 0/2] Add driver for LTP8800-1A, LTP8800-2 and LTP8800-4A Cedric Encarnacion
2024-11-06 3:09 ` [PATCH v2 1/2] dt-bindings: trivial-devices: add ltp8800 Cedric Encarnacion
2024-11-06 4:34 ` Guenter Roeck
2024-11-06 16:06 ` Conor Dooley
2024-11-06 16:11 ` Conor Dooley
2024-11-06 16:43 ` Guenter Roeck
2024-11-06 16:54 ` Conor Dooley
2024-11-06 18:19 ` Guenter Roeck
2024-11-06 18:38 ` Conor Dooley
2024-11-06 16:35 ` Guenter Roeck
2024-11-06 16:46 ` Conor Dooley
2024-11-06 18:23 ` Guenter Roeck
2024-11-06 3:09 ` [PATCH v2 2/2] hwmon: pmbus: add driver for ltp8800-1a, ltp8800-4a, and ltp8800-2 Cedric Encarnacion
2024-11-06 4:31 ` Guenter Roeck
2024-11-06 18:45 ` kernel test robot
2024-11-06 19:17 ` kernel test robot
2024-11-07 1:45 ` Guenter Roeck [this message]
2024-11-08 7:44 ` Encarnacion, Cedric justine
2024-11-08 14:31 ` Guenter Roeck
2024-11-13 5:45 ` Encarnacion, Cedric justine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697a9596-f5aa-48d0-ad26-ebe06b831ee8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=cedricjustine.encarnacion@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marex@denx.de \
--cc=noahwang.wang@outlook.com \
--cc=peteryin.openbmc@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox