From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Shirley.Lin@infineon.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, jdelvare@suse.com, corbet@lwn.net,
patrick.rudolph@9elements.com, bhelgaas@google.com,
ninad@linux.ibm.com, festevam@denx.de,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-i2c@vger.kernel.org, Mills.Liu@infineon.com,
Ashish.Yadav@infineon.com, Ian.Fang@infineon.com
Subject: Re: Update driver xdpe152c4.c
Date: Mon, 7 Apr 2025 07:01:32 -0700 [thread overview]
Message-ID: <69c8cf7c-b334-4f13-ba36-a2248686b419@roeck-us.net> (raw)
In-Reply-To: <Z_NteUAIeuDdDPls@shikoro>
On 4/6/25 23:15, Wolfram Sang wrote:
>
>> Please help to review the attached Linux Kernel patch for xdpe152xx driver.
>
> To shorten things, you could return -EAGAIN as an error code, then the
> I2C core will retry the message for you. Within the configured limits
> for the controller.
>
The patch neglects to state the _reason_ for the change.
I'd like to know what causes the problem before applying a change like this.
I suspect that the chip needs either a delay between accesses or a delay
after a write. Both are supported by the PMBus core.
Guenter
next prev parent reply other threads:[~2025-04-07 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 3:52 Update driver xdpe152c4.c Shirley.Lin
2025-04-07 4:59 ` Mukesh Kumar Savaliya
2025-04-07 6:12 ` Wolfram Sang
2025-04-07 6:58 ` Mukesh Kumar Savaliya
2025-04-07 7:23 ` Shirley.Lin
2025-04-07 6:15 ` Wolfram Sang
2025-04-07 14:01 ` Guenter Roeck [this message]
2025-04-07 14:36 ` Guenter Roeck
2025-04-08 3:28 ` Ashish.Yadav
2025-04-08 4:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69c8cf7c-b334-4f13-ba36-a2248686b419@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Ashish.Yadav@infineon.com \
--cc=Ian.Fang@infineon.com \
--cc=Mills.Liu@infineon.com \
--cc=Shirley.Lin@infineon.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox