From: Krzysztof Adamski <krzysztof.adamski@nokia.com>
To: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>,
michal.simek@xilinx.com, michal.simek@amd.com,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com
Cc: Srinivas Goud <srinivas.goud@xilinx.com>
Subject: Re: [PATCH 12/12] i2c: xiic: Correct the BNB interrupt enable sequence
Date: Wed, 29 Jun 2022 15:13:46 +0200 [thread overview]
Message-ID: <6a0df607-3d60-fd8d-54d1-3eb849d9c035@nokia.com> (raw)
In-Reply-To: <1656072327-13628-13-git-send-email-manikanta.guntupalli@xilinx.com>
W dniu 24.06.2022 o 14:05, Manikanta Guntupalli pisze:
> From: Srinivas Goud <srinivas.goud@xilinx.com>
>
> With updated AXI IIC IP core(v2.1)there is change in IP behavior
> in dynamic mode, where controller initiate read transfer on IIC
> bus only after getting the value for the number of bytes to receive.
>
> In the existing xiic_start_recv function Bus Not Busy(BNB)
> interrupt is enabled just after "slave address + start"
> write to FIFO and before the "count + stop"write to FIFO.
> Since IIC controller drives the start address of a transaction
> on the bus only after it has received the byte count information
> the above sequence can lead to spurious BNB interrupt in case
> there is any delay after "slave address + start" write to FIFO.
>
> This is fixed by ensuring that BNB interrupt is enabled only
> after "count + stop" has been written to FIFO.
>
> Signed-off-by: Srinivas Goud <srinivas.goud@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com>
> ---
[...]
Does this spurious interrupt cause any trouble or it is just ignored and
the only problem is unneeded extra CPU load?
Krzysztof
next prev parent reply other threads:[~2022-06-29 13:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 12:05 [PATCH 00/12] i2c: xiic: Added Standard mode and SMBus Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 01/12] i2c: xiic: Add standard mode support for > 255 byte read transfers Manikanta Guntupalli
2022-06-29 12:18 ` Krzysztof Adamski
2022-07-13 7:54 ` Guntupalli, Manikanta
2022-07-20 10:26 ` Krzysztof Adamski
2022-07-26 10:35 ` Guntupalli, Manikanta
2022-06-24 12:05 ` [PATCH 02/12] i2c: xiic: Enter standard mode only " Manikanta Guntupalli
2022-06-29 12:21 ` Krzysztof Adamski
2022-06-30 8:06 ` Guntupalli, Manikanta
2022-06-24 12:05 ` [PATCH 03/12] i2c: xiic: Fix Rx and Tx paths in standard mode repeated start Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 04/12] i2c: xiic: Add wait for FIFO empty in send_tx Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 05/12] i2c: xiic: Use 'nmsgs' variable instead of repeated_start Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 06/12] i2c: xiic: Add smbus_block_read functionality Manikanta Guntupalli
2022-06-29 12:25 ` Krzysztof Adamski
2022-06-24 12:05 ` [PATCH 07/12] i2c: xiic: Switch to Xiic standard mode for i2c-read Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 08/12] i2c: xiic: Remove interrupt enable/disable in Rx path Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 09/12] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 10/12] i2c: xiic: Update compatible with new IP version Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 11/12] i2c: xiic: Add SCL frequency configuration support Manikanta Guntupalli
2022-06-24 12:05 ` [PATCH 12/12] i2c: xiic: Correct the BNB interrupt enable sequence Manikanta Guntupalli
2022-06-29 13:13 ` Krzysztof Adamski [this message]
2022-07-13 8:02 ` Guntupalli, Manikanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0df607-3d60-fd8d-54d1-3eb849d9c035@nokia.com \
--to=krzysztof.adamski@nokia.com \
--cc=git@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@xilinx.com \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=srinivas.goud@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).