From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v1 1/1] i2c: atr: Remove (explicitly) unused header
Date: Thu, 3 Apr 2025 11:11:12 +0300 [thread overview]
Message-ID: <6a7fe50f-84c1-475f-b72c-64d3f672a28a@ideasonboard.com> (raw)
In-Reply-To: <20250331071646.3987361-1-andriy.shevchenko@linux.intel.com>
Hi,
On 31/03/2025 10:16, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/i2c-atr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-atr.c b/drivers/i2c/i2c-atr.c
> index 8fe9ddff8e96..783fb8df2ebe 100644
> --- a/drivers/i2c/i2c-atr.c
> +++ b/drivers/i2c/i2c-atr.c
> @@ -8,12 +8,12 @@
> * Originally based on i2c-mux.c
> */
>
> -#include <linux/fwnode.h>
> #include <linux/i2c-atr.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> +#include <linux/property.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
next prev parent reply other threads:[~2025-04-03 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:16 [PATCH v1 1/1] i2c: atr: Remove (explicitly) unused header Andy Shevchenko
2025-03-31 10:53 ` Mukesh Kumar Savaliya
2025-03-31 16:01 ` Luca Ceresoli
2025-04-03 8:11 ` Tomi Valkeinen [this message]
2025-04-15 20:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7fe50f-84c1-475f-b72c-64d3f672a28a@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=peterz@infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox