From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting Date: Sun, 24 Jul 2016 12:30:08 +0100 Message-ID: <6c46ec72-3cf2-0b8a-9a1f-38341573ccef@kernel.org> References: <20160716022831.GA7636@d830.WORKGROUP> <578C9843.10408@nvidia.com> <20160719071343.GA2086@tetsubishi> <0d515ff9-252a-a8f9-49c1-89ef0b1e9887@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58788 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbcGXLaL (ORCPT ); Sun, 24 Jul 2016 07:30:11 -0400 In-Reply-To: <0d515ff9-252a-a8f9-49c1-89ef0b1e9887@kernel.org> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Laxman Dewangan , Alison Schofield , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Linux I2C On 20/07/16 16:08, Jonathan Cameron wrote: > On 19/07/16 08:13, Wolfram Sang wrote: >> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote: >>> On 18/07/16 09:50, Laxman Dewangan wrote: >>>> >>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >>>>> auto-detection. IIO drivers don't typically use .class. >>>>> Remove it. >>>>> >>>>> Signed-off-by: Alison Schofield >>>>> Cc: Daniel Baluta >>>>> >>>> >>>> Agree. >>>> Acked-by: Laxman Dewangan >>> Any resulting ABI change from dropping it? >> >> What do you mean with ABI? This is only relevant for "automatic" >> instantiation. > Cool, I was just being paranoid and didn't have time to check! > > Thanks, > > Jonathan >> From me: >> >> Acked-by: Wolfram Sang >> > Applied to the togreg branch of iio.git - initially pushed out as testing for the autoubuilders to play with it. thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >