From: Cory Maccarrone <darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] [MISC] Add HTC PLD driver
Date: Sat, 12 Dec 2009 13:02:18 -0800 [thread overview]
Message-ID: <6cb013310912121302t30a6cb4dhf3e29b7b88ce0e0b@mail.gmail.com> (raw)
In-Reply-To: <20091207141329.3dd3411c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Mon, Dec 7, 2009 at 5:13 AM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
>
> I'm curious why your driver wouldn't work when I2C support is modular.
>
> I fail to see why you need to include that one.
>
> This define is the sure sign that your driver is badly designed. You
> shouldn't have to set any such arbitrary limit...
>
> ... because you shouldn't have to rely on a global like that in the
> first place.
>
Thanks for the feedback. I've taken it back and rewrote the driver
into something which I hope will be much more acceptable. I'll be
posting it shortly.
- Cory
prev parent reply other threads:[~2009-12-12 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 7:14 [PATCH] [MISC] Add HTC PLD driver Cory Maccarrone
[not found] ` <1260083683-13095-1-git-send-email-darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-12-07 12:49 ` Mark Brown
2009-12-07 13:13 ` Jean Delvare
[not found] ` <20091207141329.3dd3411c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-12-12 21:02 ` Cory Maccarrone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb013310912121302t30a6cb4dhf3e29b7b88ce0e0b@mail.gmail.com \
--to=darkstar6262-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).