linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cory Maccarrone <darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH v2] [MFD] i2c-htcpld: Add the HTCPLD driver
Date: Mon, 14 Dec 2009 07:30:11 -0800	[thread overview]
Message-ID: <6cb013310912140730x3ff1d1c1vf0cd851e6f7e9f7f@mail.gmail.com> (raw)
In-Reply-To: <20091214134137.GC1250-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Mon, Dec 14, 2009 at 5:41 AM, Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
>
> request_threaded_irq() probably does what you want here and is more
> friendly to things like lockdep.  There's an example of handling this
> sort of chip with the genirq infrastructure in the WM831x driver.
>

Ah, cool, I didn't know about that.  That looks to be exactly what I want.

>
> You don't need to cast awat from void.
>

Easy enough.

I'll make the changes and resubmit.  Thanks for the feedback!

- Cory

      parent reply	other threads:[~2009-12-14 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12 21:29 [PATCH v2] [MFD] i2c-htcpld: Add the HTCPLD driver Cory Maccarrone
     [not found] ` <1260653372-29299-1-git-send-email-darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-12-14 13:41   ` Mark Brown
     [not found]     ` <20091214134137.GC1250-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-12-14 15:30       ` Cory Maccarrone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb013310912140730x3ff1d1c1vf0cd851e6f7e9f7f@mail.gmail.com \
    --to=darkstar6262-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).