From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware-pcidrv: Mark expected switch fall-through
Date: Tue, 03 Jul 2018 22:16:43 +0300 [thread overview]
Message-ID: <6f9e75b62b5e93b28694e6dac2abf0a398ee3dc1.camel@linux.intel.com> (raw)
In-Reply-To: <20180703191055.GA30768@embeddedor.com>
On Tue, 2018-07-03 at 14:10 -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>
> where we are expecting to fall through.
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
> b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 86e1bd0..b4997be 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -105,6 +105,7 @@ static int mfld_setup(struct pci_dev *pdev, struct
> dw_pci_controller *c)
> case 0x0817:
> c->bus_cfg &= ~DW_IC_CON_SPEED_MASK;
> c->bus_cfg |= DW_IC_CON_SPEED_STD;
> + /* fall through */
> case 0x0818:
> case 0x0819:
> c->bus_num = pdev->device - 0x817 + 3;
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-07-03 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 19:10 [PATCH] i2c: designware-pcidrv: Mark expected switch fall-through Gustavo A. R. Silva
2018-07-03 19:16 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f9e75b62b5e93b28694e6dac2abf0a398ee3dc1.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gustavo@embeddedor.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).