From: Hans de Goede <hdegoede@redhat.com>
To: Oliver Neukum <oneukum@suse.com>,
jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-designware: increase timeout of semaphore transfer
Date: Mon, 20 Mar 2017 14:39:27 +0100 [thread overview]
Message-ID: <704db0f5-7951-3d07-1d0b-4c742dd562d0@redhat.com> (raw)
In-Reply-To: <20170320133730.23041-1-oneukum@suse.com>
Hi,
On 20-03-17 14:37, Oliver Neukum wrote:
> Our testing shows the semaphore failing to be transferred on CherryTrail
> in about 0.5% of all cases. The existing timeout needs to be lengthened
> to accomodate the worst cases.
>
> V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/i2c/busses/i2c-designware-baytrail.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c
> index 1749a0f..c0e7c88 100644
> --- a/drivers/i2c/busses/i2c-designware-baytrail.c
> +++ b/drivers/i2c/busses/i2c-designware-baytrail.c
> @@ -22,7 +22,7 @@
>
> #include "i2c-designware-core.h"
>
> -#define SEMAPHORE_TIMEOUT 100
> +#define SEMAPHORE_TIMEOUT 500
> #define PUNIT_SEMAPHORE 0x7
> #define PUNIT_SEMAPHORE_CHT 0x10e
> #define PUNIT_SEMAPHORE_BIT BIT(0)
>
next prev parent reply other threads:[~2017-03-20 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 13:37 [PATCH] i2c-designware: increase timeout of semaphore transfer Oliver Neukum
2017-03-20 13:39 ` Hans de Goede [this message]
2017-03-20 13:52 ` Jarkko Nikula
2017-03-22 8:48 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2017-03-16 16:24 Oliver Neukum
2017-03-16 16:35 ` Andy Shevchenko
2017-03-17 7:35 ` Hans de Goede
2017-03-20 13:39 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=704db0f5-7951-3d07-1d0b-4c742dd562d0@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).