From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 074F614AD3D for ; Thu, 11 Apr 2024 12:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712838096; cv=none; b=loRDpTP9LwzpfF6DHOAtXdts/jj22Rd6znkAOzieyP0uj3fz6uK0VPh/saf01trltoC5qkyNT98asgpExOnWab/0vmUsM575usGRRe1HRsQ7vjr2mVmJTd8EJqdgHrr2n/IHzPeng3BzlOVG1I+Rb8fN7IhBfq2sR8CMwjo2CRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712838096; c=relaxed/simple; bh=zHf2UPOwKhqPAUHf4IDMeXXXGq8rIrMH8W8XCAOwke0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t8me9bfasgvc+4IwJvetxNF3DzUAZ1WIi79QPUn7zsEyulylvgI4cXGI1PZHzppaGi/wO1KZnCc3WZ6wzhs8oCb66NQEKvglJfH2Pqhat7W/eqGXPBQub9lHHoLj2eU289wLhM4jneessnQxnG6OCnlGKpNINoMT0qCEldchvNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Fs65TK7c; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fs65TK7c" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3465921600dso1740523f8f.3 for ; Thu, 11 Apr 2024 05:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712838091; x=1713442891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kh1g/uh+n+SvXBwe7LtwyhGlbTwxyPzRKTm4XGWj4zM=; b=Fs65TK7cDys3ePxBYQMS8uvCNjIXf3GaGORZa08Im1m9fb6bzfhlxsMimdgiXD97So b/aA+CSJVc7wA//4NpU//lE9gCkfYNY8irevoWwvx1O2Abh4jGQWthlISEadmZ5MxwTr tyq7IN1lq6bw119PxaqMYcQoASKYf9lMHPGRmGiMMd7y7ZYPLUB0KH/DeOcFU6ZrU8wj oO08UoL41QaJA7k1r83cC1wak1uei+opgVJmQKNjIJBg1ym3nSpuks++Mt/FrLLnab4e vsPvQF183h8rVYU3iI14w0hdByPvz11BstQZcFzH9MO8bNSsPjGGo/Wwb9/EmkAU6jQE /VCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712838091; x=1713442891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kh1g/uh+n+SvXBwe7LtwyhGlbTwxyPzRKTm4XGWj4zM=; b=w4FaeNoBtwujFG+6Geroj8RzqZYhqHZlJez6YurJEdDoj5XlZgJN//WUOxKKral54T Burss0r3VpVg6GfWcv5J4R3gWxGCEtFg3kaLuL+FeNc+BrMVKjVoKxL/5ueEHP/e6NsZ C+YT46zneJkgPQvMoWRtgb9FmdiXhPeneyS42a813Txry2v4TZwxpAu1EfMQ79pr5zeJ ReEJx0ZoeyedazOMhD0YkCjz2TPFZfZniLtFKTmRiK+Y+/d2hP5MEFR/fUMK4n+Ke+aX 8pBMXdGYHQ/gxStHO7QhUmj9MmhNaQft7aNMpTkrmJmGr48zbYTGMtt4M08KLKW2opjT 8C/w== X-Forwarded-Encrypted: i=1; AJvYcCU6mRAgww+U12KmF/iYWVy3Of8A7WsSgeRcu9aohJlCS9tj/SmPYUTUKjVrggZfyYyqkB1mvDBIPyWz+QmwBqJjhg+UxcM38Bbw X-Gm-Message-State: AOJu0YyGtMe9IOStdy0y4DNmqHaL2lQ4W9gfif3Jv0x31hbmfZXy5Q48 Mv+A87Ex2wTw3TxwrsbgzWSJd3T2qlsDo9kfh8AR9eXWdW+L8nI3xCmWsr9qCAs= X-Google-Smtp-Source: AGHT+IEjuGMWfNFQ2RmwlzRXwcHh6dCuyCwEecfbbkGiJlJuwbowxBn8PEE6OGlSZab/hPjUISQMuw== X-Received: by 2002:a5d:525c:0:b0:343:5e64:ea54 with SMTP id k28-20020a5d525c000000b003435e64ea54mr3709721wrc.61.1712838091399; Thu, 11 Apr 2024 05:21:31 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id r9-20020adff109000000b00341de3abb0esm1655188wro.20.2024.04.11.05.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 05:21:31 -0700 (PDT) Message-ID: <7098c454-6a1d-46ae-aef9-63bb9ee82c6a@linaro.org> Date: Thu, 11 Apr 2024 13:21:30 +0100 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible"" To: Krzysztof Kozlowski , Vladimir Zapolskiy , Bjorn Andersson , Robert Foss , Loic Poulain , Krzysztof Kozlowski , Konrad Dybcio , Wolfram Sang Cc: Neil Armstrong , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240411085218.450237-1-vladimir.zapolskiy@linaro.org> <0b810e39-b82f-4cca-87b0-6e586690b242@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <0b810e39-b82f-4cca-87b0-6e586690b242@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2024 13:03, Krzysztof Kozlowski wrote: > On 11/04/2024 10:52, Vladimir Zapolskiy wrote: >> This reverts commit 3e383dce513f426b7d79c0e6f8afe5d22a581f58. >> >> The commit ae2a1f0f2cb5 ("dt-bindings: i2c: qcom-cci: Document sc8280xp compatible") >> was correct apparently, it is required to describe the sc8280xp-cci >> controller properly, as well it eliminates dtbs_check warnings. >> >> Signed-off-by: Vladimir Zapolskiy > > Subject: > dt-bindings: i2c: Revert .... > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof Reversion is not the right fix. I'll send a proper fix asap. cci0: cci@ac4a000 { compatible = "qcom,sc8280xp-cci", "qcom,msm8996-cci"; clock-names = "camnoc_axi", "slow_ahb_src", "cpas_ahb", "cci"; - if: properties: compatible: contains: enum: - qcom,sc7280-cci - qcom,sc8280xp-cci-no-bueno - qcom,sm8250-cci - qcom,sm8450-cci then: properties: clocks: minItems: 5 maxItems: 5 clock-names: items: - const: camnoc_axi - const: slow_ahb_src - const: cpas_ahb - const: cci - const: cci_src --- bod