Re: Creating a driver for MAX31827 temperature switch

[Armin Wolf <W_Armin@gmx.de>]

Am 02.04.23 um 23:31 schrieb Daniel Matyas:

> Dear Kernel community,
>
> I am developing an IIO driver for a temperature switch, which communicates through I2C at Analog Devices Inc.
>
> When implementing the event handling for the comparator mode of the device, I faced a problem: I don't know how to differentiate the underTemp event from the overTemp event. To understand better, I suggest you check out the device's data sheet for Address map (page 12), Configuration Register Definition (page 13) and OT/UT Status Bits and ALARM Pin Behavior (page 15) - https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31827-MAX31829.pdf
>
> I had the idea to make 2 channels with the exact same attributes, but with different indexes, so that I can store the overTemp related events on channel 0 and underTemp related events on channel 1. Even so, I don't really feel like this is the right solution. Can anyone give me some advice on this?
>
> Also, I was suggested that I convert my driver from IIO to HWMON. Do you think that this is needed?
>
> Yours faithfully,
> Daniel Matyas

Hi,

regarding the question whether the driver should be a hwmon driver: i depends on the usage of the temperature sensor.
If its a low sample rate temperature sensor used to mainly monitor the temperature of the computer system itself, then
the driver should be a hwmon driver. The datasheet suggests that the sensor device is intended for monitoring computer systems,
so a hwmon driver would make sense (see https://www.kernel.org/doc/html/latest/driver-api/iio/intro.html).

Armin Wolf