Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller

Josh Cartwright
2014-03-04T17:04:01Z

On Fri, Feb 28, 2014 at 07:06:29PM -0800, S?ren Brinkmann wrote:
> On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote:
> > Add a driver for the Cadence I2C controller. This controller is for
> > example found in Xilinx Zynq.
> >
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > ---
> > .../devicetree/bindings/i2c/i2c-cadence.txt | 21 +
> > MAINTAINERS | 1 +
> > drivers/i2c/busses/Kconfig | 7 +
> > drivers/i2c/busses/Makefile | 1 +
> > drivers/i2c/busses/i2c-cadence.c | 901 +++++++++++++++++++++
> > 5 files changed, 931 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> > create mode 100644 drivers/i2c/busses/i2c-cadence.c
> >
> [...]
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index f5ed03164d86..7806c1654068 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -375,6 +375,13 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
> > help
> > The unit of the TWI clock is kHz.
> >
> > +config I2C_CADENCE
> > + tristate "Cadence I2C Controller"
> > + depends on ARCH_ZYNQ
> This can be reduced to a dependency on COMMON_CLK only, I think.

Do you really need to depend on COMMON_CLK? Most of the clk_* API's are
properly stubbed when !HAVE_CLK.

Also, you may want to split out the device tree bindings in a separate
patch for separate review.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation