From: <Conor.Dooley@microchip.com>
To: <palmer@dabbelt.com>, <palmer@rivosinc.com>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lee.jones@linaro.org>,
<robh+dt@kernel.org>, <linux-mmc@vger.kernel.org>,
<paul.walmsley@sifive.com>, <linux-riscv@lists.infradead.org>,
<atulkhare@rivosinc.com>, <support.opensource@diasemi.com>,
<andrew@lunn.ch>, <heiko@sntech.de>,
<krzysztof.kozlowski@linaro.org>, <stwiss.opensource@diasemi.com>,
<aou@eecs.berkeley.edu>, <ulf.hansson@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name
Date: Mon, 27 Jun 2022 15:58:47 +0000 [thread overview]
Message-ID: <737ca8a9-1403-e594-b466-d652536e482e@microchip.com> (raw)
In-Reply-To: <2247394.ElGaqSPkdT@diego>
A ping and an offer:
Palmer, do you want me to take the random dt cleanups through
my tree & save you the hassle of following along with them?
Thanks,
Conor.
On 13/06/2022 15:05, Heiko Stübner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@microchip.com:
>>
>> On 06/06/2022 21:13, Conor Dooley wrote:
>>> From: Conor Dooley <conor.dooley@microchip.com>
>>>
>>> After converting the pmic watchdog binding to yaml, dtbs_check complains
>>> that the node name doesn't match the binding. "Fix" it.
>>
>> Hey Palmer,
>> The three dt-binding changes were accepted - do I need to poke SiFive to
>> ack the dts change or are you fine just taking it?
>
> I don't think a node-name has relevance to vendor decisions ;-) .
>
> Looking at bindings/watchdog/watchdog.yaml we clearly see that
> the node name is always watchdog or watchdog@foo, so this change
> is clearly correct.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
>
>> Thanks,
>> Conor.
>>
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>>> ---
>>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>> index c4ed9efdff03..1f386b07a832 100644
>>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>> @@ -90,7 +90,7 @@ rtc {
>>> compatible = "dlg,da9063-rtc";
>>> };
>>>
>>> - wdt {
>>> + watchdog {
>>> compatible = "dlg,da9063-watchdog";
>>> };
>>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>
>
>
>
>
next prev parent reply other threads:[~2022-06-27 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 20:13 [PATCH v3 0/4] clear riscv dtbs_check errors Conor Dooley
2022-06-06 20:13 ` [PATCH v3 1/4] dt-bindings: mmc: convert mmc-spi-slot to yaml Conor Dooley
2022-06-07 10:43 ` Ulf Hansson
2022-06-06 20:13 ` [PATCH v3 2/4] dt-bindings: i2c: convert ocores binding " Conor Dooley
2022-06-08 19:50 ` Wolfram Sang
2022-06-06 20:13 ` [PATCH v3 3/4] dt-bindings: mfd: convert da9063 " Conor Dooley
2022-06-08 7:48 ` Lee Jones
2022-06-06 20:13 ` [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name Conor Dooley
2022-06-13 13:33 ` Conor.Dooley
2022-06-13 14:05 ` Heiko Stübner
2022-06-27 15:58 ` Conor.Dooley [this message]
2022-07-04 16:10 ` Conor.Dooley
2022-07-14 22:04 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=737ca8a9-1403-e594-b466-d652536e482e@microchip.com \
--to=conor.dooley@microchip.com \
--cc=andrew@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=atulkhare@rivosinc.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).