Re: [PATCH v4] i2c: spacemit: introduce pio for k1

Troy Mitchell
2025-12-15T06:00:48Z

On Fri, Nov 07, 2025 at 09:50:26AM -0600, Alex Elder wrote:
> On 10/9/25 4:59 AM, Troy Mitchell wrote:
> > This patch introduces I2C PIO functionality for the Spacemit K1 SoC,
> > enabling the use of I2C in atomic context.
[...]
> > @@ -125,10 +127,14 @@ struct spacemit_i2c_dev {
> > enum spacemit_i2c_state state;
> > bool read;
> > + bool use_pio;
>
> This is fine, but you could maybe call it atomic (to match
> the callback funtion name).
>
> Actually, almost all uses of this field are negated, i.e.:
> if (!i2c->use_pio)
>
> Maybe you could use a name that doesn't require negation,
> like "can_block" for example.

Most of the negation is unnecessary; it's my code's behavior. I'll
modify the code behavior, not this variable. I believe this variable
directly reflects the hardware behavior. Therefore, I won't modify it
here.

- Troy