From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: RE: [PATCH] i2c: tegra: Fix compile when !CONFIG_OF Date: Thu, 21 Jul 2011 08:42:06 -0700 Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049EBDF141@HQMAIL01.nvidia.com> References: <1310589418-15821-1-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Ben Dooks Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Jean Delvare , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org Grant Likely wrote at Wednesday, July 13, 2011 4:48 PM: > On Thu, Jul 14, 2011 at 5:36 AM, Stephen Warren wrote: > > When !CONFIG_OF, doesn't prototype of_get_property(), which > > causes i2c-tegra.c to fail to compile. Make the references to this > > function conditional to solve this. > > > > Signed-off-by: Stephen Warren ... > Acked-by: Grant Likely Ben, please can this patch be applied in time for 3.1? Currently, the linux-next and next-i2c tree won't compile on Tegra without CONFIG_OF enabled. Also, the other patch I posted titled "i2c: Tegra: Add of_match_table" is required for Tegra I2C Device Tree support to be useful. Can that go into 3.1 as well? Thanks very much! -- nvpublic