From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: RE: Tegra I2C driver compilation failure (was: RE: [PATCH] dt: add empty of_get_property for non-dt) Date: Tue, 9 Aug 2011 10:30:21 -0700 Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04A06872DF@HQMAIL01.nvidia.com> References: <74CDBE0F657A3D45AFBB94109FB122FF04A0687289@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04A0687289-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ben Dooks Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jean Delvare , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Colin Cross , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Axel Lin , Rob Herring , Grant Likely , "marc.zyngier-5wv7dgnIgG8@public.gmane.org" List-Id: linux-i2c@vger.kernel.org Stephen Warren wrote at Tuesday, August 09, 2011 10:22 AM: > Stephen Warren wrote at Monday, August 08, 2011 1:26 PM: > > Rob Herring wrote at Sunday, August 07, 2011 8:38 AM: > > > On 08/05/2011 05:50 PM, Stephen Warren wrote: > > > > The patch adds empty function of_get_property for non-dt build, so that > > > > drivers migrating to dt can save some '#ifdef CONFIG_OF'. > > > > > > > > This also fixes the current Tegra compile problem in linux-next. > > > > > > You could just use of_property_read_u32 in the driver. It already has > > > empty version and will simplify the driver code some. > > > > Yes, that would also work. > > > > Grant, Ben, do you have a preference for which option to choose? > > Well, all three possible fixes have been posted now: > > Add ifdef to i2c driver: > http://www.spinics.net/lists/linux-tegra/msg01720.html > > Implement empty of_get_property: > http://www.spinics.net/lists/linux-tegra/msg01881.html Grant has merged this one into a devicetree branch. Thanks! > Switch i2c driver to use of_property_read_u32: > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/127807 > > Ben, please could you please pick one of the changes and apply it, so > that linux-next compiles for Tegra? Thanks! -- nvpublic