Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support

Alex Deucher
2023-11-16T19:15:30Z

On Mon, Nov 13, 2023 at 6:37 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> I2C_CLASS_SPD was used to expose the EEPROM content to user space,
> via the legacy eeprom driver. Now that this driver has been removed,
> we can remove I2C_CLASS_SPD support. at24 driver with explicit
> instantiation should be used instead.
>
> If in doubt this patch could be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.

Alex

> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 1 -
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 -
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 1a6675d70..bc56a29e6 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1527,7 +1527,6 @@ static int aldebaran_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = 0;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &aldebaran_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU 0");
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index 82c4e1f1c..c0e62bab9 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -2720,7 +2720,6 @@ static int smu_v13_0_0_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = i;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &smu_v13_0_0_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 891605d49..9de91bd77 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -1884,7 +1884,6 @@ static int smu_v13_0_6_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = i;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &smu_v13_0_6_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
> --
> 2.42.1
>