From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC184C4332F for ; Sun, 28 Nov 2021 09:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344573AbhK1J61 (ORCPT ); Sun, 28 Nov 2021 04:58:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54666 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357205AbhK1J41 (ORCPT ); Sun, 28 Nov 2021 04:56:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638093190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=46iYRFJVxEl7Q54CoIPD2LT3/f4Emo7d2PE1/uhIF0E=; b=JO/32hqlnDaFXrbh9ugyhKCt8v09jQIp1uA+d2G4K8G0Z9XkDEcRd9FRIcdY2IQ2Iy/xoK QGhwVAnCxO1uQXvmXESdU0SG0zKaLx6/l0hqpFSy4LUmSiVNQUE4/jcxD2rKQz/Q7SAo3w oNDxw6Qif2LcU8vTH7VaWiL0QKVCq54= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-NVFjFORoPke9m-3thn5WdA-1; Sun, 28 Nov 2021 04:53:09 -0500 X-MC-Unique: NVFjFORoPke9m-3thn5WdA-1 Received: by mail-ed1-f72.google.com with SMTP id q17-20020aa7da91000000b003e7c0641b9cso11239509eds.12 for ; Sun, 28 Nov 2021 01:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=46iYRFJVxEl7Q54CoIPD2LT3/f4Emo7d2PE1/uhIF0E=; b=I2gY/B8ubD6G3lGcJ7Y6EET+igZ3wWl6CNnxsdROIEaqScGnPyOCyGTrv4HQBCBL1L O3oFyCDMEmeftM2FFEKnwTY7jXZfltXxPkpb9FaysNL57ylLj+ug91q8ZwXjDe9tbnx6 0fXLsbP5RAI1xeoF2Db88InONaoCUclw2xrf3f4gDIYlYyK7D2zJDYevQb0NRDC9/Qxo QaaQ56qqakSoqQlJODyiA1TAMW3p5AWbRIUCWbrMzwr5l109TpfzkfkqHcO+1AK1ogXA wyHzRWaCgxuAUmWOktQvyC+iK7iv/ikO5MVYJbZJSp099IKQMUN25Agqr2rqn1vMKLxe YIRw== X-Gm-Message-State: AOAM5335vWAUOIgi+0z3Pt6qyM+yPHc9VfuoFfFuDANCcTnTHejdbqUf 0BvQEX6sdZOlkTEeujosY5/8M3bLSHlxuP6BULLrfvtPDelUNHCp0/+yuRQTpvQvrnYf8LuDXda hENhe4wrgD3n+H+r2kwP2 X-Received: by 2002:a17:906:788:: with SMTP id l8mr50597936ejc.548.1638093187942; Sun, 28 Nov 2021 01:53:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzPU/LDAbdbnCqEDs5hHt7m3Ne48l8FCBQpugmNlF5u5inOtqfjkaoRgqNeB8vix/j6A4+lFg== X-Received: by 2002:a17:906:788:: with SMTP id l8mr50597904ejc.548.1638093187785; Sun, 28 Nov 2021 01:53:07 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id r13sm6999064edo.71.2021.11.28.01.53.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Nov 2021 01:53:07 -0800 (PST) Message-ID: <75f4e158-3099-b138-8412-d3a987622c0a@redhat.com> Date: Sun, 28 Nov 2021 10:53:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 14/20] mfd: intel_soc_pmic_chtwc: Add intel_cht_wc_get_model() helper function Content-Language: en-US To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Mika Westerberg , Mark Gross , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , MyungJoo Ham , Chanwoo Choi , Ard Biesheuvel , Len Brown , ACPI Devel Maling List , Yauhen Kharuzhy , Tsuchiya Yuto , Platform Driver , linux-i2c , Linux PM , Linux Kernel Mailing List , linux-efi References: <20211114170335.66994-1-hdegoede@redhat.com> <20211114170335.66994-15-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 11/16/21 12:18, Andy Shevchenko wrote: > On Sun, Nov 14, 2021 at 7:04 PM Hans de Goede wrote: >> >> Tablet / laptop designs using an Intel Cherry Trail x86 main SoC with >> an Intel Whiskey Cove PMIC do not use a single standard setup for > > does not designs ... do not. Design_s_ so more then one, so "do not" is correct. >> +} >> +EXPORT_SYMBOL_GPL(intel_cht_wc_get_model); > > Are you planning to use EXPORT_SYMBOL_GPL_NS()? If not, please consider it. This will be gone in v3, since this info is now stored in struct intel_soc_pmic as requested by Chanwoo. Regards, Hans