From: Nishanth Menon <menon.nishanth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
Cc: Syed Rafiuddin <rafiuddin.syed-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH][RFC] OMAP4: I2C Support for OMAP_4430SDP
Date: Fri, 29 May 2009 20:52:01 +0300 [thread overview]
Message-ID: <782515bb0905291052h1d70be5em7cfdeeda903c39fc@mail.gmail.com> (raw)
In-Reply-To: <878wkghqzi.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
On Fri, May 29, 2009 at 6:24 PM, Kevin Hilman
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
> "Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:
>> +static int __init omap4_i2c_init(void)
>> +{
>> + omap_register_i2c_bus(1, 2600, NULL, 0);
why is this 2600? omap3 could do 3.3Mhz.
>> + omap_register_i2c_bus(2, 400, NULL, 0);
>> + omap_register_i2c_bus(3, 400, NULL, 0);
>> + return 0;
>> +}
This code badly worries me given the omap3 story and i2c bus
capacitance. The new code for omap4 should allow for scll and sclh to
be board specific configurable [1] and [2] - i would expect a similar
story kicking in again...
Regards,
Nishanth Menon
Ref:
[1] http://marc.info/?t=123540865900002&r=1&w=2
[2] http://marc.info/?t=123457935200001&r=1&w=2
next prev parent reply other threads:[~2009-05-29 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 14:38 [PATCH][RFC] OMAP4: I2C Support for OMAP_4430SDP Syed Rafiuddin
[not found] ` <55272.192.168.10.89.1243607905.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2009-05-29 15:24 ` Kevin Hilman
[not found] ` <878wkghqzi.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2009-05-29 17:52 ` Nishanth Menon [this message]
[not found] ` <782515bb0905291052h1d70be5em7cfdeeda903c39fc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-04 21:41 ` Jagadeesh Bhaskar Pakaravoor
[not found] ` <561678670906041441y4c592e61h71fd3cf6869bcf46-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-05 2:28 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782515bb0905291052h1d70be5em7cfdeeda903c39fc@mail.gmail.com \
--to=menon.nishanth-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rafiuddin.syed-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).