Re: [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag

Krzysztof Kozlowski
2024-11-25T08:11:19Z

On 17/11/2024 18:45, Mukesh Kumar Savaliya wrote:
> Thanks Rob for your review and comments !
>
> On 11/15/2024 11:01 PM, Rob Herring wrote:
>> On Wed, Nov 13, 2024 at 09:44:10PM +0530, Mukesh Kumar Savaliya wrote:
>>> Adds qcom,is-shared flag usage. Use this flag when I2C serial controller
>>
>> Doesn't match the property name.
> Sure, i need to change the name here as qcom,shared-se, will upload a
> new patch.
>>
>>> needs to be shared in multiprocessor system(APPS,Modem,ADSP) environment.
>>>
>>> Two clients from different processors can share an I2C controller for same
>>> slave device OR their owned slave devices. Assume I2C Slave EEPROM device
>>> connected with I2C controller. Each client from ADSP SS and APPS Linux SS
>>> can perform i2c transactions.
>>>
>>> Transfer gets serialized by Lock TRE + DMA xfer + Unlock TRE at HW level.
>>>
>>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>>> ---
>>> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
>>> index 9f66a3bb1f80..fe36938712f7 100644
>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
>>> @@ -60,6 +60,10 @@ properties:
>>> power-domains:
>>> maxItems: 1
>>>
>>> + qcom,shared-se:
>>
>> What is 'se'? Is that defined somewhere?
>>
> SE is Serial Engine acting as I2C controller. Let me add second line for
> SE here also.
>
> It's mentioned in source code in Patch 3 where it's used.
> >>> True if serial engine is shared between multiprocessors OR
> Execution Environment.
You already got this comment:
https://lore.kernel.org/lkml/20240927063108.2773304-4-quic_msavaliy@quicinc.com/T/#m79efdd1172631aca99a838b4bfe57943755701e3

""se" is also not explained in the binding - please open it and look for
such explanation."

Further comments asked you to rephrase it. Did anything improve? No,
nothing.

You got comments, you ignore them and send the same.

But most important: I keep repeating this over and over - NAK for some
specific "shared-se" flag, different for each of your IP blocks. Come
with something generic for entire qualcomm. There are few of such flags
already and there are some patches adding it in different flavors.

Get this consistent.

NAK for this and v5 doing exactly theh same.

Best regards,
Krzysztof