Re: [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag

Krzysztof Kozlowski
2024-11-29T15:12:49Z

On 29/11/2024 15:43, Mukesh Kumar Savaliya wrote:
>> But most important: I keep repeating this over and over - NAK for some
>> specific "shared-se" flag, different for each of your IP blocks. Come
>> with something generic for entire qualcomm. There are few of such flags
>> already and there are some patches adding it in different flavors.
>>
> we do have SE (serial engine) which works for i2c, spi, uart, i3c. And
> SE is single HW entity as you are aware of. But I feel it makes sense to
> keep this flag name per SE and even for SPI OR I3C we should be using
> same flag name in DTSI.
>> Get this consistent.
>>
>> NAK for this and v5 doing exactly theh same.
>>
> Hope i meet expectations considering all your suggestions and past
> learning and not missing anything out of my mind.
>
Nothing from my comment above was resolved. I will NAK the next version
as well for the same reasons.

Best regards,
Krzysztof