From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Yves MORDRET Subject: Re: [PATCH v2 3/6] i2c: i2c-stm32f7: Add initial SMBus protocols support Date: Wed, 4 Apr 2018 10:16:20 +0200 Message-ID: <79784d30-0a88-9aab-081f-ee14c214288b@st.com> References: <1521650940-11651-1-git-send-email-pierre-yves.mordret@st.com> <1521650940-11651-4-git-send-email-pierre-yves.mordret@st.com> <20180324224911.xz3fz2jojcdrovb4@ninjato> <2fadcd7f-3bfc-997e-a30e-808f6d854f2c@st.com> <20180403153122.ux6hnnmexwmq3soz@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180403153122.ux6hnnmexwmq3soz@ninjato> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Maxime Coquelin , Alexandre Torgue , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 04/03/2018 05:31 PM, Wolfram Sang wrote: > >>>> All SMBus protocols are implemented except SMBus-specific protocols. >>> >>> What does that mean? >> >> It miss SMBus Host Notification and SMBBus Alert. They are almost ready but I'm >> struggling to put them back to operational state after recent changes related to >> SMBust Host Notification. A more "classic" interrupt base solution has been put >> in place but I fail to use implement it in my side. >> Another patch set is going to be delivered for these 2 commands. > > This is totally fine to implement it incrementally. Please just update the > commit message with the more detailed explanation above. > Ok. I get. >>> That is quite some complexity considering we have I2C_FUNC_SMBUS_EMUL. I >>> don't mind, but you really want that? >>> >> >> All SMBBus commands are implemented as such. I never try to emulation commands. >> Should we use emulation SMBus commands or real commands... Don't know. > > You won't see any difference on the wire. I don't know your HW. It might > be that SMBus mode is more "automatic" and uses less interrupts. Or > stuff like Alert or HostNotification only works in this mode. If you and > the driver maintainers think it is worth the added complexity, I am > fine, too. > Ok. I see. I am the maintainer. So yes I keep it as such ... with this complexity ;)