From: Michal Simek <michal.simek@xilinx.com>
To: Raviteja Narayanam <rna@xilinx.com>, Marek Vasut <marex@denx.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: Re: [PATCH v2 0/6] i2c: xiic: Fix broken locking
Date: Fri, 27 Aug 2021 10:34:08 +0200 [thread overview]
Message-ID: <7a17c847-397d-b106-df95-2bac11d65e2c@xilinx.com> (raw)
In-Reply-To: <SN6PR02MB40934151B394A0F656E96B98CAC89@SN6PR02MB4093.namprd02.prod.outlook.com>
On 8/27/21 10:31 AM, Raviteja Narayanam wrote:
>
>
>> -----Original Message-----
>> From: Michal Simek <michal.simek@xilinx.com>
>> Sent: Tuesday, August 24, 2021 12:29 PM
>> To: Marek Vasut <marex@denx.de>; linux-i2c@vger.kernel.org; Raviteja
>> Narayanam <rna@xilinx.com>
>> Cc: Michal Simek <michals@xilinx.com>; Shubhrajyoti Datta
>> <shubhraj@xilinx.com>; Wolfram Sang <wsa@kernel.org>
>> Subject: Re: [PATCH v2 0/6] i2c: xiic: Fix broken locking
>>
>> +ravi
>>
>> On 8/23/21 11:41 PM, Marek Vasut wrote:
>>> Booting ZynqMP with XIIC I2C driver shows multitude of race conditions
>>> in the XIIC driver. This is because locking is completely missing from
>>> the driver, and there are odd corner cases where the hardware behaves
>>> strangely.
>>>
>>> Most of these races could be triggered easily when booting on SMP
>>> machines, like the ZynqMP which has up to 4 cores. It is sufficient
>>> for the interrupt handler to run on another core than xiic_start_xfer
>>> and the driver fails completely.
>>>
>>> This does not add support for long transfers, this only fixes the
>>> driver to be usable at all instead of being completely broken.
>>>
>>> The V2 fixes a few remaining details which cropped up in deployment
>>> over the last year or so, so I believe the result should be reasonably
>>> well tested.
>
> Thanks a lot for the patches, Marek.
> I have tested these on our boards and they are working fine.
>
> I will rebase my patch series on top of this and send after rc1.
Wolfram: Can you please merge this series? Ravi's series will come on
the top of this one.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next prev parent reply other threads:[~2021-08-27 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 21:41 [PATCH v2 0/6] i2c: xiic: Fix broken locking Marek Vasut
2021-08-23 21:41 ` [PATCH v2 1/6] i2c: xiic: Fix broken locking on tx_msg Marek Vasut
2021-08-23 21:41 ` [PATCH v2 2/6] i2c: xiic: Drop broken interrupt handler Marek Vasut
2021-08-23 21:41 ` [PATCH v2 3/6] i2c: xiic: Defer xiic_wakeup() and __xiic_start_xfer() in xiic_process() Marek Vasut
2021-08-23 21:41 ` [PATCH v2 4/6] i2c: xiic: Switch from waitqueue to completion Marek Vasut
2021-08-23 21:41 ` [PATCH v2 5/6] i2c: xiic: Only ever transfer single message Marek Vasut
2021-08-23 21:41 ` [PATCH v2 6/6] i2c: xiic: Fix RX IRQ busy check Marek Vasut
2021-08-24 6:58 ` [PATCH v2 0/6] i2c: xiic: Fix broken locking Michal Simek
2021-08-27 8:31 ` Raviteja Narayanam
2021-08-27 8:34 ` Michal Simek [this message]
2021-09-14 10:29 ` Wolfram Sang
2021-09-14 11:54 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a17c847-397d-b106-df95-2bac11d65e2c@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-i2c@vger.kernel.org \
--cc=marex@denx.de \
--cc=rna@xilinx.com \
--cc=shubhraj@xilinx.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox