From: Markus Elfring <Markus.Elfring@web.de>
To: Rosen Penev <rosenp@gmail.com>, linux-i2c@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH 1/3] i2c: ibm_iic: ioremap with platform pointer
Date: Sat, 22 Aug 2026 15:05:18 +0200 [thread overview]
Message-ID: <7ca1914c-8f32-499c-8121-4205044e330c@web.de> (raw)
In-Reply-To: <20260821230217.319418-2-rosenp@gmail.com>
> devm_platform_ioremap_resource only needs a platform_device pointer and
> calling it early allows handling potential -EPROBE_DEFER.
I find the change description improvable.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n94
Regards,
Markus
next prev parent reply other threads:[~2026-08-22 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 23:02 [PATCH 0/3] i2c: ibm_iic: use devm and get irq in probe Rosen Penev
2026-08-21 23:02 ` [PATCH 1/3] i2c: ibm_iic: ioremap with platform pointer Rosen Penev
2026-08-22 13:05 ` Markus Elfring [this message]
2026-08-21 23:02 ` [PATCH 2/3] i2c: ibm_iic: get the irq early in probe Rosen Penev
2026-08-21 23:02 ` [PATCH 3/3] i2c: ibm_iic: use devm for main allocation Rosen Penev
2026-08-22 13:12 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca1914c-8f32-499c-8121-4205044e330c@web.de \
--to=markus.elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox