Re: [PATCH v5 0/1] i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7 14AGP11

[Mario Limonciello <mario.limonciello@amd.com>]

On 5/18/26 08:40, Hardik Prakash wrote:
> On Mon, May 18, 2026 at 18:17, Mario Limonciello wrote:
>> I'd still like to avoid a quirk if we can.
>>
>> I know my proposed patch to try to probe at an earlier stage didn't
>> work, but could you perhaps try pulling pinctrl-amd even earlier?
>>
>> Maybe fs_initcall()?
> 
> Tested. fs_initcall + patch 1 still produces the same arbitration
> errors:
> 
>    subsys_initcall + patch 1:   arbitration errors persist
>    fs_initcall + patch 1:       arbitration errors persist
>    patch 1 + patch 2 (v5):     clean boot, touchscreen fully functional
> 
> The initcall level does not appear to be the determining factor on
> this hardware. i2c_designware is still probing AMDI0010:02 before
> pinctrl-amd finishes regardless of how early pinctrl-amd registers.
> The explicit device_is_bound() deferral in patch 2 is the only
> approach that has worked.

Please try arch_initcall instead.

> 
> Thanks,
> Hardik
> 
> On Mon, 18 May 2026 at 18:17, Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>>
>>
>> On 5/18/26 07:28, Hardik Prakash wrote:
>>> Patch 1/2 (pinctrl-amd GPIO IRQ fix) is already in Linus Walleij's
>>> tree. This series contains only the i2c-designware probe ordering fix,
>>> based on top of that commit.
>>>
>>> The root cause: i2c_designware probes AMDI0010:02 before pinctrl-amd
>>> completes, so GPIO 157 (WACF2200 GpioInt per ACPI _CRS) has its
>>> interrupt bits cleared when the first I2C transaction is attempted,
>>> causing lost arbitration errors.
>>>
>>> A higher-level ACPI devlink approach was investigated in response to
>>> Bartosz Golaszewski's suggestion. The DSDT has no _DEP object linking
>>> AMDI0010:02 to AMDI0030:00, so fw_devlink has nothing to act on.
>>> Setting this up at the ACPI layer would require either a firmware
>>> change to add _DEP, or a DMI quirk in the ACPI scan path — equally
>>> quirk-based as the current approach.
>>
>> I'd still like to avoid a quirk if we can.
>>
>> I know my proposed patch to try to probe at an earlier stage didn't
>> work, but could you perhaps try pulling pinctrl-amd even earlier?
>>
>> Maybe fs_initcall()?
>>
>>>
>>> v5:
>>>    - Add blank line before #include <linux/acpi.h> (Bartosz Golaszewski)
>>>    - Use scoped_guard(device, gpio_dev) (Bartosz Golaszewski)
>>>
>>> v4:
>>>    - Rebase onto Linus Walleij's tree (patch 1 already there)
>>>    - Use --base so series is correctly 1/1 (Andy Shevchenko)
>>>    - Add subsys_initcall test results (Mario Limonciello)
>>>
>>> v3:
>>>    - Fix variable declaration style in dw_i2c_needs_amd_gpio_dep (Andy Shevchenko)
>>>    - Add BugLink tag (Andy Shevchenko)
>>>    - Add -v3 subject versioning (Andy Shevchenko)
>>>    - CC AMD engineers (Andy Shevchenko)
>>>
>>> v2:
>>>    - Replace custom HID/UID lookup with acpi_dev_get_first_match_dev() (Andy Shevchenko)
>>>    - Use acpi_get_first_physical_node() for platform device lookup
>>>    - Use device_is_bound() under device_lock() with explanatory comments
>>>    - Fix dev_warn to use dev_name() instead of hardcoded suffix
>>>    - Fix commit message (removed incorrect "existing" reference)
>>>    - Add Assisted-by tags per coding-assistants.rst
>>>
>>> Kernel bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=221494
>>> Related: https://bugzilla.kernel.org/show_bug.cgi?id=221454
>>>
>>> Hardik Prakash (1):
>>>     i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7
>>>       14AGP11
>>>
>>>    drivers/i2c/busses/i2c-designware-platdrv.c | 76 +++++++++++++++++++++
>>>    1 file changed, 76 insertions(+)
>>>
>>> base-commit: 3812a9e84265a5cdd90d29fe8d97a023e91fb945
>>