From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Rajat Jain <rajatja@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, dtor@google.com
Cc: rajatxjain@gmail.com, dbasehore@chromium.org
Subject: Re: [PATCH 1/3] i2c: designware: Enable async suspend / resume of designware devices
Date: Fri, 22 Oct 2021 14:37:36 +0300 [thread overview]
Message-ID: <7d94d015-ebff-ee46-3726-9091fe3cdff4@linux.intel.com> (raw)
In-Reply-To: <20211022022859.1888836-2-rajatja@google.com>
On 10/22/21 5:28 AM, Rajat Jain wrote:
> Mark the designware devices for asynchronous suspend. With this, the
> resume for designware devices does not get stuck behind other unrelated
> devices (e.g. intel_backlight that takes hundreds of ms to resume,
> waiting for its parent devices).
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 21113665ddea..2bd81abc86f6 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -293,6 +293,8 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> DPM_FLAG_MAY_SKIP_RESUME);
> }
>
> + device_enable_async_suspend(&pdev->dev);
> +
> /* The code below assumes runtime PM to be disabled. */
> WARN_ON(pm_runtime_enabled(&pdev->dev));
>
I guess same can be done to i2c_dw_pci_probe() too. I don't have any
strong opinion should it be done in this patch or somewhere in the future.
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2021-10-22 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 2:28 [PATCH 0/3] i2c: Enable async resume for i2c devices Rajat Jain
2021-10-22 2:28 ` [PATCH 1/3] i2c: designware: Enable async suspend / resume of designware devices Rajat Jain
2021-10-22 11:37 ` Jarkko Nikula [this message]
2021-10-22 16:53 ` Dmitry Torokhov
2021-10-22 2:28 ` [PATCH 2/3] i2c: enable async suspend/resume for i2c adapters Rajat Jain
2021-10-22 2:28 ` [PATCH 3/3] i2c: enable async suspend/resume on i2c client devices Rajat Jain
2021-10-22 11:50 ` [PATCH 0/3] i2c: Enable async resume for i2c devices Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d94d015-ebff-ee46-3726-9091fe3cdff4@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dbasehore@chromium.org \
--cc=dtor@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).