From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] i2c: designware: Fix false warning from i2c_dw_clk_rate()
Date: Wed, 17 May 2017 09:12:11 +0300 [thread overview]
Message-ID: <7f48d8e6-4e24-a463-1d65-85b63d90f844@linux.intel.com> (raw)
In-Reply-To: <20170516212914.bjc77ogqbklm4udi@ninjato>
On 05/17/2017 12:29 AM, Wolfram Sang wrote:
>
>>> + switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) {
>>> + case DW_IC_CON_SPEED_STD:
>>> + i2c_dw_set_timings_sm(dev);
>>> + break;
>>> + case DW_IC_CON_SPEED_FAST:
>>> + i2c_dw_set_timings_fm(dev);
>>> + break;
>>> + case DW_IC_CON_SPEED_HIGH:
>>> + i2c_dw_set_timings_hsm(dev);
>>> + break;
>>> }
>>
>> I would put same suffixes to the helper functions, i.e.
>> _sm -> _std
>> _fm -> _fast
>> _hsm-> _high
>
> BTW is this a bugfix? I tend to think, yes.
>
Maybe in grey area but not enough for linux-stable I think. Unless log
spamming qualifies as a regression.
Lorenzo: does my patch fix the issue for you? I was waiting your comment
before sending version 2 addressing Andy's comment.
--
Jarkko
next prev parent reply other threads:[~2017-05-17 6:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 12:49 [PATCH] i2c: designware: Fix false warning from i2c_dw_clk_rate() Jarkko Nikula
2017-05-11 14:00 ` Andy Shevchenko
2017-05-16 21:29 ` Wolfram Sang
2017-05-17 6:12 ` Jarkko Nikula [this message]
2017-05-19 7:12 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f48d8e6-4e24-a463-1d65-85b63d90f844@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).