From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] arm64: dts: meson-a1: add I2C nodes Date: Tue, 10 Dec 2019 10:43:06 -0800 Message-ID: <7hwob4owcl.fsf@baylibre.com> References: <20191202111253.94872-1-jian.hu@amlogic.com> <1j8snkh4cz.fsf@starbuckisacylon.baylibre.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1j8snkh4cz.fsf@starbuckisacylon.baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Jerome Brunet , Jian Hu , Neil Armstrong Cc: Rob Herring , Martin Blumenstingl , Michael Turquette , Wolfram Sang , Mark Rutland , Jianxin Pan , linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Jerome Brunet writes: > On Mon 02 Dec 2019 at 12:12, Jian Hu wrote: > >> There are four I2C controllers in A1 series, >> Share the same comptible with AXG.The I2C nodes >> depend on pinmux and clock controller. >> >> Signed-off-by: Jian Hu >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 149 ++++++++++++++++++++++ >> 1 file changed, 149 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> index eab2ecd36aa8..d0a73d953f5e 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> @@ -16,6 +16,13 @@ >> #address-cells = <2>; >> #size-cells = <2>; >> >> + aliases { >> + i2c0 = &i2c0; >> + i2c1 = &i2c1; >> + i2c2 = &i2c2; >> + i2c3 = &i2c3; >> + }; >> + > > I wonder if assigning i2c bus alias in the SoC dtsi is such a good idea. > > Such aliases are usually assigned as needed by each board design: > meson-a1-ad401.dts in your case. Agreed. I don't think SoC-wide aliases are a great idea. Kevin