From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29318310621 for ; Mon, 3 Nov 2025 18:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762195407; cv=none; b=m0EdOb5lYc6fJhPK5x0P/WZD+BBt1m3P0LG6j0iSavosBh8qMv8uQZxvQ1XDMpYWr5nvsag8CWl4qH9w2UXXIc8XcBfjFKiVPF3TsQ0Q2bIqhROhken4nMtYqQ3yx0mOxFFhwYN35Ms8ROcbSflKZzo+1H1gpy8zFqffKRA9cqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762195407; c=relaxed/simple; bh=/GzKpLC6PmQOMk52lWhyCWqg2aaUKd2qMnQB0++1v6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mOk1n8yqsFVuOcA3vANGI8toVhEA6MqJneRRT8ZdaBGJI7XrkZX2HwKw9/EsUKV0G1lJV8PDy3aEvB/Zh6Wq6/pgAMlfiGdRk2Yi814CYdqOPesarQ3jWZHe7DdA0eECnrkn5HBeQpndRe5paM0uAiiKRtJuBv9vTFPbNoMzwt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WZDPVvQg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SoGaV+UO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WZDPVvQg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SoGaV+UO" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A3GgMCI3736346 for ; Mon, 3 Nov 2025 18:43:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c5+d4jykJaGaK4q6+ofZATU9EzTTNPt9yANrk9kKwWI=; b=WZDPVvQgQxWgsKOT dT0cIk+8+nS4rTh30074AFYVUew/j23DuEHXBP6Mt9NPWp0RueEJMriyYvtzyzeS z2t070Vg7zk+hfYXPAszz3seLeKZBrRNGdfJ7ByYP1lCdgO0zkFjaaWqoyyB1NVa VxlqjnCsh1o43CU7agK4RQcV5kl8t3Za3brFGd9bM8+OcGrByDV50fsEALUqCaGj oTAPpgUR/QiYF/7HP/zeXhjagkMId4E6JzSWy4RCsoFdPYmfi1b9bridXowAEzME iKB1hyUkhWLX4cqmwDfk0Ex4eqGJwq0juzXMa+g9iIu/nW+aDImbjdYQarqqVEnL R+ZyDw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a6s86hp16-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Nov 2025 18:43:24 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b62da7602a0so3716630a12.2 for ; Mon, 03 Nov 2025 10:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762195404; x=1762800204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c5+d4jykJaGaK4q6+ofZATU9EzTTNPt9yANrk9kKwWI=; b=SoGaV+UOd3t+Sb1SdzgSAuVUWns2d9fGnTkCf+5CZE889S8J4qi9auFwFVeRrWzCNz niXm9CSG0W7g47xiYQn9cbwXQ72ptJ45H42E4A19dTBQh85gROdU5ngWwO2hFXRkgRJb yQgATHkTp4ThIy7N11Pdi6UepxziWNv8AnNUes2REXCymQgRvxKS3ERcLKWF20SI5ORF 2nnqmTm+M0nVMhXEC6pTqkROsVvgGjCx6l804TxXFGkVDTNFDF4Eg3w5UyQiU3ylRppA x03Qe6NQ685g3Yr71X84nXbiQwQcz5deF4sK53EJ0apJB7/2RxE8S9vG3PQapVwuEj6r HZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762195404; x=1762800204; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5+d4jykJaGaK4q6+ofZATU9EzTTNPt9yANrk9kKwWI=; b=uFUjKMxp3nakeK/srh8JlijnHbxxFGtlpQeF5HRKJ268dz2pS0OfT3xgQ9fljj/ZDf oFryYYXqcN7nX1vV3v31/N+0yNwqeubPo8NF8agjbbT+hOtEfYY6kJPNh36jOqJ5BhvW Rn+L8y99S84haK4WOTHEsvSeQLaWL+CjajpVAPsKeNY0PjoSVyS65SzFHKpuXnAexTsd MSNx6itPe5RDz1QDeD87MuxmP/OXfQPHfwx+4eikXZJt/YYHwXP1J1qXAZUh4r/jBEtj LhVQUeCfgeNZdlLqtDqMCgiL5kF6y1/AAjQQ2VU9IfAQ2rSePw+BEOEAA550g8Ie1wTe clgQ== X-Forwarded-Encrypted: i=1; AJvYcCVMi2Z8kVm8yAmmR5/xwuh4K/W+VgnL8tk/MnqxNI6nChUPY6dTziWZKMnjg2nU7tK//7/FAdKXE6o=@vger.kernel.org X-Gm-Message-State: AOJu0YxO/fQ4zJqG7QLrGgvwGfzjGiTQcjX/RJ87uwLzhpfvpm5AI/ta U8Wtg5Dad49GQrZzwIosNrmw9svJu9lg9L9u8qPkFV8G/hPhBFRN6W817IDlMEiub45OC1WQNh8 iJ54qElpF5tY+L/Ag8emSF/2zs3nH9R1bzsi//bQ9LjjvbrD55XPIqDd4YzCbWNs= X-Gm-Gg: ASbGnct148W+oqDyhfP3pA11gREmP4kKdsmEIubHNxURN29/KtvCUj86bIaEjPgqYgp veKjWJeUNZkAAaxrr3Hv2WbWZ7pZvm0qWcp6qdlr0vsfesyeNlGvikPOSFafbjnekIw0zWql3dJ Poi+tKgUrd2dBTFzWI5k2nFlSSRPmtuzg+sNNCxVKHs43ZWwtIfyqqPx3+Ii9U6D7P6Af1UlSTZ OYvRtv2ECUww5Xn6qe7cVIzT06R/BC/pszLBEab2CvETOITzd6Br0kUwOdzFGMcze/C7Gg4/3ob DUFPhtPuK7mS0/YQLt1V7s2pjO4LQXSukbWZeGz3sShLF6SYcN7D7z2jIW05ILPkRVzobcbKeNc br+epgDIf7RQmtqGF+fJCGnE21WQcnIIuYj8VlQ6wadi8YtzDbQ13MA== X-Received: by 2002:a05:6a20:3d8e:b0:342:9cb7:64a3 with SMTP id adf61e73a8af0-348cbda9bc9mr17950912637.34.1762195403767; Mon, 03 Nov 2025 10:43:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdThbEmXK0CuxBH1/c5R33FC/ss8+vn/2FSzn25CBYYPmQnSb4Y6drTofKNBCE33oGQcIuUQ== X-Received: by 2002:a05:6a20:3d8e:b0:342:9cb7:64a3 with SMTP id adf61e73a8af0-348cbda9bc9mr17950873637.34.1762195403090; Mon, 03 Nov 2025 10:43:23 -0800 (PST) Received: from [10.62.37.19] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b9b8f2b5403sm4879826a12.17.2025.11.03.10.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Nov 2025 10:43:22 -0800 (PST) Message-ID: <8083f0d8-6fe5-45df-b5d9-f8d4e04a5cbb@oss.qualcomm.com> Date: Mon, 3 Nov 2025 10:43:20 -0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/6] media: dt-bindings: Add CAMSS device for Kaanapali To: Krzysztof Kozlowski Cc: Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251030-add-support-for-camss-on-kaanapali-v5-0-f8e12bea3d02@oss.qualcomm.com> <20251030-add-support-for-camss-on-kaanapali-v5-2-f8e12bea3d02@oss.qualcomm.com> <631e4da1-92a0-4d44-b92e-bdcc56196c26@linaro.org> <20251102-charming-angelfish-of-experiment-eaa4bc@kuoka> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <20251102-charming-angelfish-of-experiment-eaa4bc@kuoka> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTAzMDE2NyBTYWx0ZWRfX6mD7L0NFKOqz sSqpSp8s06mHkNBkJ1AfQroI+leShq7i2h80NVgAwWv2BoXqiYvhL9gPxQS3frOMgLswTPwK0wH UyWl4M3w7zxhmQRFarhfH6pjkfksXKaMOt/jiujQeXD9BuU17vb/yRiP2sFhjzqg+4aaWqgWimC 5maKZM5iVqzprsu9mR+PABYFBmFrfI0mcyI5Fw0iKhezmNqMWTJ58M5A/5bzDz5hTDIx2Xnj8Cs RJmpyxr7WXB+oQQuAgF0oV3bxdN7WlMQFEFmyKcvA7pWX2jwqSKJq/G4e/bjIxZchZwPaQp2iFl 8JHML0e+Ld/dkncj/Xqe4juRJzZiRvd8MHhuGRdv/nOP+FjRGmeDLP3P84MLc1SND8LZ0XsXb8Q GTwOWnBMlU5nNMB3c0lpzfby4SEzWw== X-Authority-Analysis: v=2.4 cv=Tq/rRTXh c=1 sm=1 tr=0 ts=6908f7cc cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=fy5AM4a-v69lRwORk0gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: XXYFCZNCR_93h89zt5sDBldnHRk49neo X-Proofpoint-ORIG-GUID: XXYFCZNCR_93h89zt5sDBldnHRk49neo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-03_04,2025-11-03_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511030167 On 11/2/2025 8:06 AM, Krzysztof Kozlowski wrote: > On Fri, Oct 31, 2025 at 10:39:44AM -0700, Vijay Kumar Tumati wrote: >> On 10/31/2025 6:50 AM, Bryan O'Donoghue wrote: >>> On 31/10/2025 02:59, Hangxiang Ma wrote: >>>> Add the compatible string "qcom,kaanapali-camss" to support the Camera >>>> Subsystem (CAMSS) on the Qualcomm Kaanapali platform. >>>> >>>> The Kaanapali platform provides: >>>> - 3 x VFE, 5 RDI per VFE >>>> - 2 x VFE Lite, 4 RDI per VFE Lite >>>> - 3 x CSID >>>> - 2 x CSID Lite >>>> - 6 x CSIPHY >>>> >>>> Signed-off-by: Hangxiang Ma >>>> --- >>>>   .../bindings/media/qcom,kaanapali-camss.yaml       | 406 >>>> +++++++++++++++++++++ >>>>   1 file changed, 406 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml >>>> b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml >>>> new file mode 100644 >>>> index 000000000000..c34867022fd1 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml >>>> @@ -0,0 +1,406 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/media/qcom,kaanapali-camss.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Qualcomm Kaanapali Camera Subsystem (CAMSS) >>>> + >>>> +maintainers: >>>> +  - Hangxiang Ma >>>> + >>>> +description: >>>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. >>>> + >>>> +properties: >>>> +  compatible: >>>> +    const: qcom,kaanapali-camss >>>> + >>>> +  reg: >>>> +    maxItems: 16 >>>> + >>>> +  reg-names: >>>> +    items: >>>> +      - const: csid0 >>>> +      - const: csid1 >>>> +      - const: csid2 >>>> +      - const: csid_lite0 >>>> +      - const: csid_lite1 >>>> +      - const: csiphy0 >>>> +      - const: csiphy1 >>>> +      - const: csiphy2 >>>> +      - const: csiphy3 >>>> +      - const: csiphy4 >>>> +      - const: csiphy5 >>>> +      - const: vfe0 >>>> +      - const: vfe1 >>>> +      - const: vfe2 >>>> +      - const: vfe_lite0 >>>> +      - const: vfe_lite1 >>> No test pattern generator on this part ? >>> >>> We have patches in-flight to add TPG so it makes no sense to omit these >>> registers from current or new submissions. >>> >>> https://lore.kernel.org/linux-media/20251017-camss_tpg-v5-1-cafe3ad42163@oss.qualcomm.com/ >>> >>> >>> While we're at it we should consider adding in the other key functional >>> blocks. >>> >>> OFE, IPE etc, there's no harm in including the registers even if the >>> intention and outcome is never switching that functionality on. >>> >> Hi Bryan, we have quite a few register spaces on Kaanapali or any other >> target that are not required for the RDI only CAMSS driver, including ICP, > Please read writing bindings doc. It answers this question exactly. > > I'm marking it as changes requested in DT patchwork. > > Best regards, > Krzysztof Sure, thank you Bryan, Krzysztof. Appreciate your inputs and patience. We will address this in the next revision.