Linux I2C development
 help / color / mirror / Atom feed
From: Ben Gardner <gardner.ben-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ds2482: Discard obsolete detect method
Date: Tue, 22 Sep 2009 15:08:07 -0500	[thread overview]
Message-ID: <808c8e9d0909221308u44798896u9a0e87d63e6feab7@mail.gmail.com> (raw)
In-Reply-To: <20090920133459.1455416e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

On Sun, Sep 20, 2009 at 6:34 AM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> There is no point in implementing a detect callback for the DS2482, as
> this device can't be detected. It was there solely to handle "force"
> module parameters to instantiate devices, but now we have a better sysfs
> interface that can do the same.
>
> So we can get rid of the ugly module parameters and the detect callback.
> This shrinks the binary module size by 21%.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Ben Gardner <gardner.ben-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Ben Gardner <gardner.ben-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

> +$ echo ds2482 0x18 > /sys/bus/i2c/devices/i2c-0/new_device

I learned something new today. =)

Thanks,
Ben

      parent reply	other threads:[~2009-09-22 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20 11:34 [PATCH] ds2482: Discard obsolete detect method Jean Delvare
     [not found] ` <20090920133459.1455416e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-22 20:08   ` Ben Gardner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=808c8e9d0909221308u44798896u9a0e87d63e6feab7@mail.gmail.com \
    --to=gardner.ben-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox