From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01003C4332E for ; Thu, 14 Jan 2021 18:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8D7C23A34 for ; Thu, 14 Jan 2021 18:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729516AbhANSGU (ORCPT ); Thu, 14 Jan 2021 13:06:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729272AbhANSGU (ORCPT ); Thu, 14 Jan 2021 13:06:20 -0500 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [IPv6:2001:4b7a:2000:18::165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B3DBC061575 for ; Thu, 14 Jan 2021 10:05:25 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 8A9441F531; Thu, 14 Jan 2021 19:05:23 +0100 (CET) Subject: Re: [PATCH v2 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties To: Bjorn Andersson Cc: agross@kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, phone-devel@vger.kernel.org References: <20210114174909.399284-1-angelogioacchino.delregno@somainline.org> <20210114174909.399284-4-angelogioacchino.delregno@somainline.org> From: AngeloGioacchino Del Regno Message-ID: <80ecc187-9694-9be9-a910-e03366968e0a@somainline.org> Date: Thu, 14 Jan 2021 19:05:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Il 14/01/21 18:58, Bjorn Andersson ha scritto: > On Thu 14 Jan 11:49 CST 2021, AngeloGioacchino Del Regno wrote: > >> Document the new noise rejection properties "qcom,noise-reject-sda" >> and "qcom,noise-reject-scl". >> > > I presume these are unit-less levels? > > Yes, there is no unit. Sorry, I've sent v3 before seeing your R-b on this. > Reviewed-by: Bjorn Andersson > > Regards, > Bjorn > >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../devicetree/bindings/i2c/qcom,i2c-qup.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml >> index c5c7db3ac2a6..3f14dd65c6b9 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml >> @@ -58,6 +58,20 @@ properties: >> '#size-cells': >> const: 0 >> >> + qcom,noise-reject-sda: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Noise rejection level for the SDA line. >> + minimum: 0 >> + maximum: 3 >> + default: 0 >> + >> + qcom,noise-reject-scl: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Noise rejection level for the SCL line. >> + minimum: 0 >> + maximum: 3 >> + default: 0 >> + >> required: >> - compatible >> - clocks >> -- >> 2.29.2 >>