Re: [PATCH net-next v2 6/6] net: txgbe: Support phylink MAC layer

Andrew Lunn
2023-04-11T12:43:12Z

> > @@ -204,7 +205,7 @@ static int txgbe_request_irq(struct wx *wx)
> >
> > static void txgbe_up_complete(struct wx *wx)
> > {
> > - u32 reg;
> > + struct txgbe *txgbe = (struct txgbe *)wx->priv;
>
> Personal choice I guess, but normally we tend to rely on compilers
> accepting the implicit cast from void * to whatever struct pointer
> in the kernel.

Davem used to strongly push back against a cast when the pointer was a
void *. Please remove the cast.

Andrew