From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Sanket Goswami <Sanket.Goswami@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
michael.j.ruhl@intel.com, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 1/9] i2c: designware: Add some flexiblity to the model info
Date: Fri, 9 Feb 2024 16:14:37 +0200 [thread overview]
Message-ID: <849af5df-4b7d-493c-ad70-b99fc322af90@linux.intel.com> (raw)
In-Reply-To: <ZcJQljILDGq9Xk_A@smile.fi.intel.com>
On 2/6/24 17:30, Andy Shevchenko wrote:
> On Tue, Feb 06, 2024 at 04:51:50PM +0200, Jarkko Nikula wrote:
>> From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
>>
>> Currently the way to identify a model is via a bit field, of which
>> 4 bits are currently defined.
>>
>> Use a shifted value to that more models can be defined.
>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> While this is true review, internally we're still discussing
> the possibility of moving to plain numbers and shift, so we
> may add arrays which are indexed in model-based way.
>
I was thinking I'll drop these first 3 patches in the next version and
go back to v1 version. IMHO it's better this patchset to focus
implementing generic polling only and not mix with cleaning up the
semaphore or other random stuff.
So planning to go back to v1 version and take your notes for v2 7/9 and
9/9. What would you think?
next prev parent reply other threads:[~2024-02-09 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 14:51 [PATCH v2 0/9] i2c: designware: Generic polling mode code Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 1/9] i2c: designware: Add some flexiblity to the model info Jarkko Nikula
2024-02-06 15:30 ` Andy Shevchenko
2024-02-09 14:14 ` Jarkko Nikula [this message]
2024-02-09 14:25 ` Andy Shevchenko
2024-02-06 14:51 ` [PATCH v2 2/9] i2c: designware: Convert arbitration semaphore flag as semaphore type Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 3/9] i2c: designware: Convert shared_with_punit boolean " Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 4/9] i2c: designware: Uniform initialization flow for polling mode Jarkko Nikula
2024-02-06 15:13 ` Andy Shevchenko
2024-02-06 14:51 ` [PATCH v2 5/9] i2c: designware: Do not enable interrupts shortly in " Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 6/9] i2c: designware: Use accessors to DW_IC_INTR_MASK register Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 7/9] i2c: designware: Move interrupt handling functions before i2c_dw_xfer() Jarkko Nikula
2024-02-06 15:18 ` Andy Shevchenko
2024-02-06 14:51 ` [PATCH v2 8/9] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 9/9] i2c: designware: Implement generic polling mode code for " Jarkko Nikula
2024-02-06 15:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=849af5df-4b7d-493c-ad70-b99fc322af90@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox